Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2364903002: MIPS: Port [turbofan] ARM64: Use zr for zeroing stack slots (Closed)

Created:
4 years, 3 months ago by ivica.bogosavljevic
Modified:
4 years, 2 months ago
Reviewers:
balazs.kilvady, miran.karic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Port [turbofan] ARM64: Use zr for zeroing stack slots Port f84f45f9ca808a0829df76bf9da712d4c1f51ed7 Original commit message: When zeroing a floating point stack slot, store the zero register directly, rather than storing zero moved to an FP register. BUG= Committed: https://crrev.com/298ef1728c6aa6511fb35e82b7097cd4cd23f8ba Cr-Commit-Position: refs/heads/master@{#39906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 3 months ago (2016-09-23 13:14:20 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 2 months ago (2016-09-30 08:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364903002/1
4 years, 2 months ago (2016-09-30 09:03:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 09:05:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 09:06:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298ef1728c6aa6511fb35e82b7097cd4cd23f8ba
Cr-Commit-Position: refs/heads/master@{#39906}

Powered by Google App Engine
This is Rietveld 408576698