Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 2364843002: Merged: [turbofan] Fix loop assignment analysis on ForInStatements. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647887.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parsing/parser.h" 7 #include "src/parsing/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 VisitIfNotNull(loop->init()); 245 VisitIfNotNull(loop->init());
246 Enter(loop); 246 Enter(loop);
247 VisitIfNotNull(loop->cond()); 247 VisitIfNotNull(loop->cond());
248 Visit(loop->body()); 248 Visit(loop->body());
249 VisitIfNotNull(loop->next()); 249 VisitIfNotNull(loop->next());
250 Exit(loop); 250 Exit(loop);
251 } 251 }
252 252
253 253
254 void ALAA::VisitForInStatement(ForInStatement* loop) { 254 void ALAA::VisitForInStatement(ForInStatement* loop) {
255 Expression* l = loop->each();
255 Enter(loop); 256 Enter(loop);
256 Visit(loop->each()); 257 Visit(l);
257 Visit(loop->subject()); 258 Visit(loop->subject());
258 Visit(loop->body()); 259 Visit(loop->body());
260 if (l->IsVariableProxy()) AnalyzeAssignment(l->AsVariableProxy()->var());
259 Exit(loop); 261 Exit(loop);
260 } 262 }
261 263
262 264
263 void ALAA::VisitForOfStatement(ForOfStatement* loop) { 265 void ALAA::VisitForOfStatement(ForOfStatement* loop) {
264 Visit(loop->assign_iterator()); 266 Visit(loop->assign_iterator());
265 Enter(loop); 267 Enter(loop);
266 Visit(loop->next_result()); 268 Visit(loop->next_result());
267 Visit(loop->result_done()); 269 Visit(loop->result_done());
268 Visit(loop->assign_each()); 270 Visit(loop->assign_each());
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 int count = 0; 311 int count = 0;
310 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 312 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
311 for (size_t i = 0; i < list_.size(); i++) { 313 for (size_t i = 0; i < list_.size(); i++) {
312 if (list_[i].second->Contains(var_index)) count++; 314 if (list_[i].second->Contains(var_index)) count++;
313 } 315 }
314 return count; 316 return count;
315 } 317 }
316 } // namespace compiler 318 } // namespace compiler
317 } // namespace internal 319 } // namespace internal
318 } // namespace v8 320 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647887.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698