Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2364843002: Merged: [turbofan] Fix loop assignment analysis on ForInStatements. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: [turbofan] Fix loop assignment analysis on ForInStatements. Revision: 4dab7b5a1d6722002d47d0be2481cb65602a2451 BUG=chromium:647887 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org, hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/e6ff184457db4d7726639c61d69dd80f44a8ad5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-647887.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-23 08:28:22 UTC) #1
Michael Starzinger
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 3 months ago (2016-09-23 08:28:23 UTC) #2
Benedikt Meurer
LFTM
4 years, 3 months ago (2016-09-23 08:29:19 UTC) #3
Benedikt Meurer
LGTM
4 years, 3 months ago (2016-09-23 08:29:24 UTC) #4
Michael Starzinger
4 years, 3 months ago (2016-09-23 08:32:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6ff184457db4d7726639c61d69dd80f44a8ad5e.

Powered by Google App Engine
This is Rietveld 408576698