Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: cc/resources/texture_mailbox_deleter.cc

Issue 23648014: cc: Move TextureMailbox::ReleaseCallback to SingleReleaseCallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: releasecallback: missingfiles Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/texture_mailbox_deleter.h" 5 #include "cc/resources/texture_mailbox_deleter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
11 #include "cc/output/context_provider.h" 11 #include "cc/output/context_provider.h"
12 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h" 12 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
13 13
14 namespace cc { 14 namespace cc {
15 15
16 static void DeleteTextureOnImplThread( 16 static void DeleteTextureOnImplThread(
17 const scoped_refptr<ContextProvider>& context_provider, 17 const scoped_refptr<ContextProvider>& context_provider,
18 unsigned texture_id, 18 unsigned texture_id,
19 unsigned sync_point, 19 unsigned sync_point,
20 bool is_lost) { 20 bool is_lost) {
21 if (sync_point) 21 if (sync_point)
22 context_provider->Context3d()->waitSyncPoint(sync_point); 22 context_provider->Context3d()->waitSyncPoint(sync_point);
23 context_provider->Context3d()->deleteTexture(texture_id); 23 context_provider->Context3d()->deleteTexture(texture_id);
24 } 24 }
25 25
26 static void PostTaskFromMainToImplThread( 26 static void PostTaskFromMainToImplThread(
27 scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner, 27 scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner,
28 TextureMailbox::ReleaseCallback run_impl_callback, 28 ReleaseCallback run_impl_callback,
29 unsigned sync_point, 29 unsigned sync_point,
30 bool is_lost) { 30 bool is_lost) {
31 // This posts the task to RunDeleteTextureOnImplThread(). 31 // This posts the task to RunDeleteTextureOnImplThread().
32 impl_task_runner->PostTask( 32 impl_task_runner->PostTask(
33 FROM_HERE, base::Bind(run_impl_callback, sync_point, is_lost)); 33 FROM_HERE, base::Bind(run_impl_callback, sync_point, is_lost));
34 } 34 }
35 35
36 TextureMailboxDeleter::TextureMailboxDeleter() : weak_ptr_factory_(this) {} 36 TextureMailboxDeleter::TextureMailboxDeleter() : weak_ptr_factory_(this) {}
37 37
38 TextureMailboxDeleter::~TextureMailboxDeleter() { 38 TextureMailboxDeleter::~TextureMailboxDeleter() {
39 for (size_t i = 0; i < impl_callbacks_.size(); ++i) 39 for (size_t i = 0; i < impl_callbacks_.size(); ++i)
40 impl_callbacks_.at(i)->Run(0, true); 40 impl_callbacks_.at(i)->RunAndReset(0, true);
41 } 41 }
42 42
43 TextureMailbox::ReleaseCallback TextureMailboxDeleter::GetReleaseCallback( 43 ScopedReleaseCallback TextureMailboxDeleter::GetReleaseCallback(
44 const scoped_refptr<ContextProvider>& context_provider, 44 const scoped_refptr<ContextProvider>& context_provider,
45 unsigned texture_id) { 45 unsigned texture_id) {
46 // This callback owns a reference on the |context_provider|. It must be 46 // This callback owns a reference on the |context_provider|. It must be
47 // destroyed on the impl thread. Upon destruction of this class, the 47 // destroyed on the impl thread. Upon destruction of this class, the
48 // callback must immediately be destroyed. 48 // callback must immediately be destroyed.
49 scoped_ptr<TextureMailbox::ReleaseCallback> impl_callback( 49 scoped_ptr<ScopedReleaseCallback> impl_callback(
50 new TextureMailbox::ReleaseCallback(base::Bind( 50 new ScopedReleaseCallback(base::Bind(&DeleteTextureOnImplThread,
51 &DeleteTextureOnImplThread, context_provider, texture_id))); 51 context_provider,
52 texture_id)));
52 53
53 impl_callbacks_.push_back(impl_callback.Pass()); 54 impl_callbacks_.push_back(impl_callback.Pass());
54 55
55 // The raw pointer to the impl-side callback is valid as long as this 56 // The raw pointer to the impl-side callback is valid as long as this
56 // class is alive. So we guard it with a WeakPtr. 57 // class is alive. So we guard it with a WeakPtr.
57 TextureMailbox::ReleaseCallback run_impl_callback = 58 ReleaseCallback run_impl_callback(
58 base::Bind(&TextureMailboxDeleter::RunDeleteTextureOnImplThread, 59 base::Bind(&TextureMailboxDeleter::RunDeleteTextureOnImplThread,
59 weak_ptr_factory_.GetWeakPtr(), 60 weak_ptr_factory_.GetWeakPtr(),
60 impl_callbacks_.back()); 61 impl_callbacks_.back()));
61 62
62 // Provide a callback for the main thread that posts back to the impl 63 // Provide a callback for the main thread that posts back to the impl
63 // thread. 64 // thread.
64 TextureMailbox::ReleaseCallback main_callback = 65 ScopedReleaseCallback main_callback(
65 base::Bind(&PostTaskFromMainToImplThread, 66 base::Bind(&PostTaskFromMainToImplThread,
66 base::MessageLoopProxy::current(), 67 base::MessageLoopProxy::current(),
67 run_impl_callback); 68 run_impl_callback));
68 69
69 return main_callback; 70 return main_callback.Pass();
70 } 71 }
71 72
72 void TextureMailboxDeleter::RunDeleteTextureOnImplThread( 73 void TextureMailboxDeleter::RunDeleteTextureOnImplThread(
73 TextureMailbox::ReleaseCallback* impl_callback, 74 ScopedReleaseCallback* impl_callback,
74 unsigned sync_point, 75 unsigned sync_point,
75 bool is_lost) { 76 bool is_lost) {
76 for (size_t i = 0; i < impl_callbacks_.size(); ++i) { 77 for (size_t i = 0; i < impl_callbacks_.size(); ++i) {
77 if (impl_callbacks_.at(i)->Equals(*impl_callback)) { 78 if (impl_callbacks_.at(i)->Equals(*impl_callback)) {
78 // Run the callback, then destroy it here on the impl thread. 79 // Run the callback, then destroy it here on the impl thread.
79 impl_callback->Run(sync_point, is_lost); 80 impl_callback->RunAndReset(sync_point, is_lost);
80 impl_callbacks_.erase(impl_callbacks_.begin() + i); 81 impl_callbacks_.erase(impl_callbacks_.begin() + i);
81 return; 82 return;
82 } 83 }
83 } 84 }
84 85
85 NOTREACHED() << "The Callback returned by GetDeleteCallback() was called " 86 NOTREACHED() << "The Callback returned by GetDeleteCallback() was called "
86 << "more than once."; 87 << "more than once.";
87 } 88 }
88 89
89 } // namespace cc 90 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698