Issue 23648009: a small fix: DependentCode contains check against related dependency group

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23648009: a small fix: DependentCode contains check against related dependency group (Closed)

Created:
7 years, 3 months ago by weiliang.lin2

Modified:
7 years, 3 months ago

Reviewers:
ulan, Yang

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

a small fix: DependentCode contains check against related dependency group BUG= R=ulan@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16627

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
		src/objects.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

LGTM. Ulan, could you take a second look before I land this?

7 years, 3 months ago (2013-09-10 15:21:37 UTC) #2

Yang

7 years, 3 months ago (2013-09-10 16:42:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16627 (presubmit successful).