Web MIDI: tentative sysex check for receiving messages

Source/modules/webmidi/MIDIAccess.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 64 matching lines @@
     if (enable)
         m_accessor->startSession();
     else
         permissionDenied();
 }
 
 void MIDIAccess::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version)
 {
     ASSERT(isMainThread());
 
     // FIXME: Pass in |this| to create() method so we can filter system exclusive messages correctly.

[kouhei (in TOK), 2013/09/09 00:46:52]

Should this comment be deleted?

[Takashi Toyoshima, 2013/09/12 05:02:44]

Done in another CL.

-    m_inputs.append(MIDIInput::create(scriptExecutionContext(), id, manufacturer, name, version));
+    m_inputs.append(MIDIInput::create(this, scriptExecutionContext(), id, manufacturer, name, version));
 }
 
 void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
 {
     ASSERT(isMainThread());
 
     unsigned portIndex = m_outputs.size();
     m_outputs.append(MIDIOutput::create(this, portIndex, scriptExecutionContext(), id, manufacturer, name, version));
 }
 
@@ skipping 81 matching lines @@
 
 void MIDIAccess::permissionDenied()
 {
     ASSERT(isMainThread());
 
     m_hasAccess = false;
     m_promise->reject(DOMError::create("SecurityError"));
 }
 
 } // namespace WebCore