Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2364743003: [js-perf-test] add microbenchmarks for String Iterators (Closed)

Created:
4 years, 3 months ago by caitp
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-test] add microbenchmarks for String Iterators Add some micro-benchmarks to help measure the impact and benefit of String Iterator optimizations. BUG=v8:5388 R=bmeurer@chromium.org Committed: https://crrev.com/72d5c98e9031d177839c6c730e1902ae1decd2ec Cr-Commit-Position: refs/heads/master@{#39690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -2 lines) Patch
M test/js-perf-test/JSTests.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + test/js-perf-test/StringIterators/run.js View 1 chunk +3 lines, -2 lines 0 comments Download
A test/js-perf-test/StringIterators/string-iterator.js View 1 chunk +239 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
caitp
Hi, PTAL Just some benchmarks to help measure the StringIterator work in progress in other ...
4 years, 3 months ago (2016-09-23 15:07:24 UTC) #1
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-23 17:31:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364743003/1
4 years, 3 months ago (2016-09-23 18:32:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 19:03:47 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:04:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72d5c98e9031d177839c6c730e1902ae1decd2ec
Cr-Commit-Position: refs/heads/master@{#39690}

Powered by Google App Engine
This is Rietveld 408576698