Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2364733003: [Android] Switch adb_reverse_forwarder to argparse. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch adb_reverse_forwarder to argparse. Also, add newlines to host forwarder error logging. BUG= Committed: https://crrev.com/d9bce3909e31c1d7ef17c56e61181e0b53788cda Cr-Commit-Position: refs/heads/master@{#420552}

Patch Set 1 #

Patch Set 2 : slight cleaning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -40 lines) Patch
M build/android/adb_reverse_forwarder.py View 1 3 chunks +46 lines, -33 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 3 months ago (2016-09-23 01:11:06 UTC) #2
rnephew (Reviews Here)
On 2016/09/23 01:11:06, jbudorick wrote: lgtm
4 years, 3 months ago (2016-09-23 01:34:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364733003/20001
4 years, 3 months ago (2016-09-23 01:35:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 02:39:51 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 02:43:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9bce3909e31c1d7ef17c56e61181e0b53788cda
Cr-Commit-Position: refs/heads/master@{#420552}

Powered by Google App Engine
This is Rietveld 408576698