Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2364703003: [TTS] Update Contextual Cards response decoding for v1. (Closed)

Created:
4 years, 3 months ago by Donn Denman
Modified:
4 years, 3 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Update Contextual Cards response decoding for v1. Updates and simplifies the decoding of the Contextual Cards response data: 1) Add reading of the caption and thumbnail directly from the root level. 2) Remove full JSON response decoding. BUG=647041 Committed: https://crrev.com/9dc7fa1fe3baae058c22118e729d32e3bb1bfd09 Cr-Commit-Position: refs/heads/master@{#420467}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -125 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 4 chunks +5 lines, -40 lines 1 comment Download
M chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc View 3 chunks +12 lines, -79 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Donn Denman
Theresa, PTAL. Thanks!
4 years, 3 months ago (2016-09-22 20:39:22 UTC) #2
Theresa
lgtm https://codereview.chromium.org/2364703003/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc File chrome/browser/android/contextualsearch/contextual_search_delegate.cc (right): https://codereview.chromium.org/2364703003/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc#newcode501 chrome/browser/android/contextualsearch/contextual_search_delegate.cc:501: // Get the basic Bar data for Now ...
4 years, 3 months ago (2016-09-22 20:54:02 UTC) #3
Donn Denman
On 2016/09/22 20:54:02, Theresa Wellington wrote: > lgtm > > https://codereview.chromium.org/2364703003/diff/1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc > File chrome/browser/android/contextualsearch/contextual_search_delegate.cc > ...
4 years, 3 months ago (2016-09-22 20:55:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364703003/1
4 years, 3 months ago (2016-09-22 20:56:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 21:37:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:39:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dc7fa1fe3baae058c22118e729d32e3bb1bfd09
Cr-Commit-Position: refs/heads/master@{#420467}

Powered by Google App Engine
This is Rietveld 408576698