Add network throttling as an enterprise policy

chrome/browser/chromeos/net/network_throttling_observer_unittest.cc

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/chromeos/net/network_throttling_observer.h"
+#include "chrome/common/pref_names.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/mock_shill_manager_client.h"
+#include "chromeos/network/network_state_handler.h"
+#include "components/prefs/pref_registry_simple.h"
+#include "components/prefs/testing_pref_service.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+using testing::Mock;
+using testing::NiceMock;
+
+namespace chromeos {
+
+namespace test {
+
+class NetworkThrottlingObserverTest : public ::testing::Test {
+ public:
+  NetworkThrottlingObserverTest() : message_loop_(new base::MessageLoop()) {
+    DBusThreadManager::Initialize();
+    std::unique_ptr<DBusThreadManagerSetter> dbus_setter =
+        DBusThreadManager::GetSetterForTesting();
+    mock_manager_client_ = new NiceMock<MockShillManagerClient>();
+    dbus_setter->SetShillManagerClient(
+        std::unique_ptr<ShillManagerClient>(mock_manager_client_));
+    NetworkStateHandler::InitializeForTest();
+    NetworkHandler::Initialize();
+    local_state_ = new TestingPrefServiceSimple();
+    local_state_->registry()->RegisterDictionaryPref(
+        prefs::kNetworkThrottlingEnabled);
+    observer_.reset(new NetworkThrottlingObserver(local_state_));
+  }
+
+  ~NetworkThrottlingObserverTest() override { delete mock_manager_client_; }
+
+  std::unique_ptr<base::MessageLoop> message_loop_;
+  std::unique_ptr<NetworkThrottlingObserver> observer_;
+  TestingPrefServiceSimple* local_state_;
+  MockShillManagerClient* mock_manager_client_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NetworkThrottlingObserverTest);
+};
+
+TEST_F(NetworkThrottlingObserverTest, ThrottlingChangeCallsShill) {
+  // Test that a direct call to OnPreferenceChanged leads to
+  // shill_manager_client being called.
+  EXPECT_CALL(*mock_manager_client_, SetNetworkThrottlingStatus(_, _, _, _, _))
+      .Times(1);
+  observer_->OnPreferenceChanged(prefs::kNetworkThrottlingEnabled);

[Andrew T Wilson (Slow), 2016/10/28 14:31:54]

This test is a bad reason to make OnPreferenceChanged() public. Why do you need
to call this directly here?

+  Mock::VerifyAndClearExpectations(mock_manager_client_);
+
+  // Test that a change in the throttling policy value leads to
+  // shill_manager_client being called.
+  base::DictionaryValue updated_throttling_policy;
+  bool enabled = true;
+  uint32_t upload_rate = 1200;
+  uint32_t download_rate = 2000;
+  updated_throttling_policy.SetBoolean("enabled", enabled);
+  updated_throttling_policy.SetInteger("upload_rate_kbits", upload_rate);
+  updated_throttling_policy.SetInteger("download_rate_kbits", download_rate);
+  EXPECT_CALL(
+      *mock_manager_client_,
+      SetNetworkThrottlingStatus(enabled, upload_rate, download_rate, _, _))
+      .Times(1);
+  local_state_->Set(prefs::kNetworkThrottlingEnabled,

[Andrew T Wilson (Slow), 2016/10/28 14:31:54]

Can you test what happens if you then clear/remove this preference? Shill should
be called again to disable throttling, right?

+                    updated_throttling_policy);
+}
+
+}  // namespace test
+}  // namespace chromeos