Issue 23647011: Unify computation of load stubs in stub cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23647011: Unify computation of load stubs in stub cache. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Unify computation of load stubs in stub cache. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16660

Patch Set 2 : Addressed comments by Toon Verwaest. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -220 lines)			Patch
M	src/ic.cc	View		9 chunks	+17 lines, -16 lines	0 comments	Download
M	src/stub-cache.h	View	1	15 chunks	+61 lines, -76 lines	0 comments	Download
M	src/stub-cache.cc	View		6 chunks	+36 lines, -128 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h#newcode649 src/stub-cache.h:649: case Code::STORE_IC: return GDBJITInterface::LOAD_IC; GDB..::STORE_IC

7 years, 3 months ago (2013-09-07 13:14:46 UTC) #2

Michael Starzinger

Thanks for the review. Addressed comments. Landing. https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h#newcode649 src/stub-cache.h:649: case Code::STORE_IC: ...

7 years, 3 months ago (2013-09-11 15:22:40 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-09-11 15:44:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16660 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23647011: Unify computation of load stubs in stub cache. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Toon Verwaest. #

Messages