Add a missing null check for FontFaceSet::document()

Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176, 649272
NOTRY=true

Committed: https://crrev.com/13205fef7fb4691d21338b4752c79f4e1c7001f3
Cr-Commit-Position: refs/heads/master@{#420591}

[Kunihiko Sakamoto, 2016-09-23 04:27:36]

Description was changed from

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() call getExecutionContext() inside it,
so the returned value should be checked after r419951.

BUG=610176,649272
==========

to

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
==========

[Kunihiko Sakamoto, 2016-09-23 04:28:04]

ksakamoto@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-23 04:34:01]

The r419951 was reverted (because of this crash).

Do you think that adding the null check is a right fix? It seems that this is
not the only place FontFaceSet is accessing getExecutionContext() without having
the null check.

Maybe do you want to add a Member<Document> to FontFaceSet to add a strong
reference from FontFaceSet and Document?

[haraken, 2016-09-23 06:11:40]

On 2016/09/23 04:34:01, haraken wrote:
> The r419951 was reverted (because of this crash).
> 
> Do you think that adding the null check is a right fix? It seems that this is
> not the only place FontFaceSet is accessing getExecutionContext() without
having
> the null check.
> 
> Maybe do you want to add a Member<Document> to FontFaceSet to add a strong
> reference from FontFaceSet and Document?

Chatted offline. In other places where getExecutionContext() is used, it's
already guaranteed that getExecutionContext() never returns null. So
fireDoneEventIfPossible() is the only place that needs the null check.

LGTM.

[Kunihiko Sakamoto, 2016-09-23 06:13:23]

The CQ bit was checked by ksakamoto@chromium.org

[commit-bot: I haz the power, 2016-09-23 06:13:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 09:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:18:20]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Kunihiko Sakamoto, 2016-09-23 09:21:32]

The CQ bit was checked by ksakamoto@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 10:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 10:35:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-09-23 10:36:43]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-09-23 10:37:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 11:05:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-09-23 11:06:36]

Description was changed from

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
==========

to

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true
==========

[haraken, 2016-09-23 11:06:42]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-09-23 11:07:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:28:49]

Description was changed from

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true
==========

to

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-23 11:28:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 11:33:13]

Description was changed from

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true
==========

to

==========
Add a missing null check for FontFaceSet::document()

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true

Committed: https://crrev.com/13205fef7fb4691d21338b4752c79f4e1c7001f3
Cr-Commit-Position: refs/heads/master@{#420591}
==========

[commit-bot: I haz the power, 2016-09-23 11:33:14]

Patchset 1 (id:??) landed as
https://crrev.com/13205fef7fb4691d21338b4752c79f4e1c7001f3
Cr-Commit-Position: refs/heads/master@{#420591}