Add swarming task for nanobench upload

Add swarming task for nanobench upload

BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003

Committed: https://skia.googlesource.com/skia/+/f23dc49893a63de0efcfb0e45570b4b47b20c9bf

[borenet2, 2016-09-22 18:51:27]

Description was changed from

==========
Add recipe for nanobench upload

BUG=skia:
==========

to

==========
Add recipe for nanobench upload

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003
==========

[borenet, 2016-09-22 19:54:01]

Description was changed from

==========
Add recipe for nanobench upload

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003
==========

to

==========
Add swarming task for nanobench upload

BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003
==========

[borenet, 2016-09-22 19:54:14]

borenet@google.com changed reviewers:
+ borenet@google.com, jcgregorio@google.com, rmistry@google.com

[rmistry, 2016-09-23 12:01:29]

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:71: 'zone': 'us-central1-c',
Why specify the zone at all? It should not matter where the GCE instance is
created. If you want to ensure that it is GCE and not bare-metal then maybe use
machine_type dimension?

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:479: is_trybot):
is_trybot is not used anymore

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/upl...
File infra/bots/recipes/upload_nano_results.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/upl...
infra/bots/recipes/upload_nano_results.py:51: gsutil = 'gsutil'
Nit: This seems like an unnecessary abstraction which could be inlined.

[borenet, 2016-09-23 12:14:32]

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:71: 'zone': 'us-central1-c',
On 2016/09/23 12:01:28, rmistry wrote:
> Why specify the zone at all? It should not matter where the GCE instance is
> created. If you want to ensure that it is GCE and not bare-metal then maybe
use
> machine_type dimension?

Yeah, I didn't really want to limit to a specific machine type, so I figured
specifying the zone which most of our instances are in would be less
restrictive.

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:479: is_trybot):
On 2016/09/23 12:01:29, rmistry wrote:
> is_trybot is not used anymore

Removed.

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/upl...
File infra/bots/recipes/upload_nano_results.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/upl...
infra/bots/recipes/upload_nano_results.py:51: gsutil = 'gsutil'
On 2016/09/23 12:01:29, rmistry wrote:
> Nit: This seems like an unnecessary abstraction which could be inlined.

Removed. I was sure I'd have to provide an absolute path or something but didn't
end up needing to.

[rmistry, 2016-09-23 12:21:22]

lgtm

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:71: 'zone': 'us-central1-c',
On 2016/09/23 12:14:32, borenet wrote:
> On 2016/09/23 12:01:28, rmistry wrote:
> > Why specify the zone at all? It should not matter where the GCE instance is
> > created. If you want to ensure that it is GCE and not bare-metal then maybe
> use
> > machine_type dimension?
> 
> Yeah, I didn't really want to limit to a specific machine type, so I figured
> specifying the zone which most of our instances are in would be less
> restrictive.

This can change at any time. We could easily end up moving to a different zone
in us-central1 in the future and forget to update this. Even gpu:"none" is
probably better here.

[borenet, 2016-09-23 12:22:56]

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2364693003/diff/220001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:71: 'zone': 'us-central1-c',
On 2016/09/23 12:21:21, rmistry wrote:
> On 2016/09/23 12:14:32, borenet wrote:
> > On 2016/09/23 12:01:28, rmistry wrote:
> > > Why specify the zone at all? It should not matter where the GCE instance
is
> > > created. If you want to ensure that it is GCE and not bare-metal then
maybe
> > use
> > > machine_type dimension?
> > 
> > Yeah, I didn't really want to limit to a specific machine type, so I figured
> > specifying the zone which most of our instances are in would be less
> > restrictive.
> 
> This can change at any time. We could easily end up moving to a different zone
> in us-central1 in the future and forget to update this. Even gpu:"none" is
> probably better here.

Is gpu:none only set for GCE? Or is it also set for machines which do not have
discrete GPUs?

[borenet, 2016-09-23 12:28:59]

Changed to gpu:none

[rmistry, 2016-09-23 12:46:52]

On 2016/09/23 12:28:59, borenet wrote:
> Changed to gpu:none

https://chromium-swarm.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=...

A few RPis are showing up in there. I thought they were all supposed to be
os:Android, but devices haven't been hooked up to them yet?

LGTM

[rmistry, 2016-09-23 12:49:21]

Showed the above link to Kevin. Adding him to this CL for comments.

[borenet, 2016-09-23 12:52:16]

On 2016/09/23 12:49:21, rmistry wrote:
> Showed the above link to Kevin. Adding him to this CL for comments.

Ugh. Added CPU dimension, ie
https://chromium-swarm.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=...

[kjlubick, 2016-09-23 12:52:32]

On 2016/09/23 at 12:52:16, borenet wrote:
> On 2016/09/23 12:49:21, rmistry wrote:
> > Showed the above link to Kevin. Adding him to this CL for comments.
> 
> Ugh. Added CPU dimension, ie
https://chromium-swarm.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=...

With the CPU dimension, lgtm

[rmistry, 2016-09-23 12:53:10]

On 2016/09/23 12:52:32, kjlubick wrote:
> On 2016/09/23 at 12:52:16, borenet wrote:
> > On 2016/09/23 12:49:21, rmistry wrote:
> > > Showed the above link to Kevin. Adding him to this CL for comments.
> > 
> > Ugh. Added CPU dimension, ie
>
https://chromium-swarm.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=...
> 
> With the CPU dimension, lgtm

I like this CL so much I am going to lgtm a third time.

[borenet, 2016-09-23 12:54:03]

On 2016/09/23 12:53:10, rmistry wrote:
> On 2016/09/23 12:52:32, kjlubick wrote:
> > On 2016/09/23 at 12:52:16, borenet wrote:
> > > On 2016/09/23 12:49:21, rmistry wrote:
> > > > Showed the above link to Kevin. Adding him to this CL for comments.
> > > 
> > > Ugh. Added CPU dimension, ie
> >
>
https://chromium-swarm.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=...
> > 
> > With the CPU dimension, lgtm
> 
> I like this CL so much I am going to lgtm a third time.

LGTM  Me too! Me too!

[borenet, 2016-09-23 12:54:13]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-09-23 12:54:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 13:37:59]

Description was changed from

==========
Add swarming task for nanobench upload

BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003
==========

to

==========
Add swarming task for nanobench upload

BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003

Committed:
https://skia.googlesource.com/skia/+/f23dc49893a63de0efcfb0e45570b4b47b20c9bf
==========

[commit-bot: I haz the power, 2016-09-23 13:38:00]

Committed patchset #15 (id:280001) as
https://skia.googlesource.com/skia/+/f23dc49893a63de0efcfb0e45570b4b47b20c9bf