Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2364693002:
[DevTools] Use selected target for console eval (Closed)
|
Created:
4 years, 3 months ago by eostroukhov Modified:
4 years, 3 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Use selected target for console eval
BUG=649382
Committed: https://crrev.com/77a668611c71f50b70c09dcc1203fdd85278e959
Cr-Commit-Position: refs/heads/master@{#420453}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== [DevTools] Use selected target for console eval BUG=649382 ========== to ========== [DevTools] Use selected target for console eval BUG=649382 ==========
eostroukhov@chromium.org changed reviewers: + einbinder@chromium.org, lushnikov@chromium.org
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Use selected target for console eval BUG=649382 ========== to ========== [DevTools] Use selected target for console eval BUG=649382 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Use selected target for console eval BUG=649382 ========== to ========== [DevTools] Use selected target for console eval BUG=649382 Committed: https://crrev.com/77a668611c71f50b70c09dcc1203fdd85278e959 Cr-Commit-Position: refs/heads/master@{#420453} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/77a668611c71f50b70c09dcc1203fdd85278e959 Cr-Commit-Position: refs/heads/master@{#420453} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
