Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2364683004: cc: Add cache purging to software image decode controller. (Closed)

Created:
4 years, 2 months ago by vmpstr
Modified:
4 years, 2 months ago
Reviewers:
haraken, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org, haraken, tasak
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add cache purging to software image decode controller. This patch adds code that reacts to memory state change signals to purge unlocked discardable memory when we're throttled or suspended. R=ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/ac08f57b9e35a48416126cedc6177beb257459f7 Cr-Commit-Position: refs/heads/master@{#420750}

Patch Set 1 #

Total comments: 2

Patch Set 2 : memory: update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M cc/tiles/software_image_decode_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 1 4 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
vmpstr
Please take a look.
4 years, 2 months ago (2016-09-23 18:33:06 UTC) #2
ericrk
https://codereview.chromium.org/2364683004/diff/1/cc/tiles/software_image_decode_controller.cc File cc/tiles/software_image_decode_controller.cc (right): https://codereview.chromium.org/2364683004/diff/1/cc/tiles/software_image_decode_controller.cc#newcode44 cc/tiles/software_image_decode_controller.cc:44: const size_t kSuspectedMaxItemsInCache = 0; I suspect you meant ...
4 years, 2 months ago (2016-09-23 20:18:52 UTC) #3
vmpstr
PTAL
4 years, 2 months ago (2016-09-23 20:35:18 UTC) #4
ericrk
lgtm
4 years, 2 months ago (2016-09-23 20:54:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364683004/20001
4 years, 2 months ago (2016-09-23 20:56:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 22:41:08 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ac08f57b9e35a48416126cedc6177beb257459f7 Cr-Commit-Position: refs/heads/master@{#420750}
4 years, 2 months ago (2016-09-23 22:48:08 UTC) #10
haraken
4 years, 2 months ago (2016-09-25 22:41:19 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698