Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 2364683002: Adding strings for forthcoming Win 10 welcome page. (Closed)

Created:
4 years, 3 months ago by tmartino
Modified:
4 years, 3 months ago
Reviewers:
rpop, anthonyvd
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding strings for forthcoming Win 10 welcome page. BUG=648686 Committed: https://crrev.com/24dfd18e12d406910b81fe04110cc6335b5ba91a Cr-Commit-Position: refs/heads/master@{#420668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tmartino
Howdy, friendly PMs. Here are the Win 10 strings promised! Please take a look and ...
4 years, 3 months ago (2016-09-22 18:21:23 UTC) #2
rpop
On 2016/09/22 18:21:23, tmartino wrote: > Howdy, friendly PMs. Here are the Win 10 strings ...
4 years, 3 months ago (2016-09-23 16:04:22 UTC) #3
tmartino
-ewald +anthonyvd
4 years, 3 months ago (2016-09-23 17:26:24 UTC) #7
anthonyvd
lgtm
4 years, 3 months ago (2016-09-23 17:31:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364683002/1
4 years, 3 months ago (2016-09-23 18:16:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 18:23:54 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:27:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24dfd18e12d406910b81fe04110cc6335b5ba91a
Cr-Commit-Position: refs/heads/master@{#420668}

Powered by Google App Engine
This is Rietveld 408576698