Null CPDF_CountedObj::m_pObj prior to deletion

Null CPDF_CountedObj::m_pObj prior to deletion

This gives additional protection in case of re-entry. Also
make CFX_CountRef more robust in face of errors.

BUG=649229
Committed: https://pdfium.googlesource.com/pdfium/+/fef62e1f2bbf064100e6e262a10653f2374bfd2b

[Tom Sepez, 2016-09-22 17:40:37]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 17:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:54:06]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-22 17:59:11]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-09-22 17:59:12]

Lei, Dan, for review.

[Tom Sepez, 2016-09-22 18:00:13]

Description was changed from

==========
Null CPDF_CountedObj::m_pObj prior to deletion

This gives additional protection in case of re-entry.

BUG=649229
==========

to

==========
Null CPDF_CountedObj::m_pObj prior to deletion

This gives additional protection in case of re-entry. Also
make CFX_CountRef more robust in face of errors.

BUG=649229
==========

[dsinclair, 2016-09-22 18:01:45]

lgtm w/ question

https://codereview.chromium.org/2364673002/diff/1/core/fxcrt/include/cfx_coun...
File core/fxcrt/include/cfx_count_ref.h (right):

https://codereview.chromium.org/2364673002/diff/1/core/fxcrt/include/cfx_coun...
core/fxcrt/include/cfx_count_ref.h:70: intptr_t m_RefCount;
Any idea why this is intptr_t?

[Tom Sepez, 2016-09-22 18:10:19]

https://codereview.chromium.org/2364673002/diff/1/core/fxcrt/include/cfx_coun...
File core/fxcrt/include/cfx_count_ref.h (right):

https://codereview.chromium.org/2364673002/diff/1/core/fxcrt/include/cfx_coun...
core/fxcrt/include/cfx_count_ref.h:70: intptr_t m_RefCount;
On 2016/09/22 18:01:44, dsinclair wrote:
> Any idea why this is intptr_t?

Funny you should ask.  Just discussing this on another thread.
See comment in cfx_string_data_template.h

[Tom Sepez, 2016-09-22 18:13:04]

> Funny you should ask.  Just discussing this on another thread.
> See comment in cfx_string_data_template.h
... and the "Would prefer" comment in cfx_string_data_template.h
isn't 100% accurate, either.

[Tom Sepez, 2016-09-22 18:21:31]

PS#2 adds a comment and fixes the old comment.

[dsinclair, 2016-09-22 18:22:29]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-22 18:22:30]

lgtm

[commit-bot: I haz the power, 2016-09-22 18:22:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:37:17]

Description was changed from

==========
Null CPDF_CountedObj::m_pObj prior to deletion

This gives additional protection in case of re-entry. Also
make CFX_CountRef more robust in face of errors.

BUG=649229
==========

to

==========
Null CPDF_CountedObj::m_pObj prior to deletion

This gives additional protection in case of re-entry. Also
make CFX_CountRef more robust in face of errors.

BUG=649229

Committed:
https://pdfium.googlesource.com/pdfium/+/fef62e1f2bbf064100e6e262a10653f2374b...
==========

[commit-bot: I haz the power, 2016-09-22 18:37:18]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/fef62e1f2bbf064100e6e262a10653f2374b...