core/fpdfapi/fpdf_font/include/cpdf_font.h - Issue 2364643003: Make CPDF_Font::Create() return a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/include/cpdf_font.h

Issue 2364643003: Make CPDF_Font::Create() return a std::unique_ptr. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/include/cpdf_font.h

diff --git a/core/fpdfapi/fpdf_font/include/cpdf_font.h b/core/fpdfapi/fpdf_font/include/cpdf_font.h

index a47d8655c259b732becf3fae6c617d9df5ce427d..eb91524320fd53b784679f0c813908ab31157b01 100644

--- a/core/fpdfapi/fpdf_font/include/cpdf_font.h

+++ b/core/fpdfapi/fpdf_font/include/cpdf_font.h

@@ -38,8 +38,8 @@ class CPDF_ToUnicodeMap;

class CPDF_Font {

public:

- static CPDF_Font* CreateFontF(CPDF_Document* pDoc,

- CPDF_Dictionary* pFontDict);

+ static std::unique_ptr<CPDF_Font> Create(CPDF_Document* pDoc,

+ CPDF_Dictionary* pFontDict);

static CPDF_Font* GetStockFont(CPDF_Document* pDoc,

const CFX_ByteStringC& fontname);

static const uint32_t kInvalidCharCode = static_cast<uint32_t>(-1);