Make CPDF_Font::Create() return a std::unique_ptr.

Make CPDF_Font::Create() return a std::unique_ptr.

Committed: https://pdfium.googlesource.com/pdfium/+/3f4111fbff1233de9f5c67eda433bee0f5f88c4e

[Tom Sepez, 2016-09-22 21:08:04]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-22 21:08:04]

Dan, for review.

https://codereview.chromium.org/2364643003/diff/1/core/fpdfapi/fpdf_page/fpdf...
File core/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right):

https://codereview.chromium.org/2364643003/diff/1/core/fpdfapi/fpdf_page/fpdf...
core/fpdfapi/fpdf_page/fpdf_page_doc.cpp:153: pFontData->reset(pFont.release());
note: these become std::move() down the road.

[Tom Sepez, 2016-09-22 21:34:20]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org
- dsinclair@chromium.org

[Tom Sepez, 2016-09-22 21:34:28]

Lei, for review.

[Lei Zhang, 2016-09-23 01:47:29]

thestig@chromium.org changed reviewers:
+ npm@chromium.org

[Lei Zhang, 2016-09-23 01:47:29]

Maybe npm@ can review this one?

What's with the core/fxcrt/include/#cfx_weak_ptr.h# file?

[Tom Sepez, 2016-09-23 02:05:10]

On 2016/09/23 01:47:29, Lei Zhang wrote:
> Maybe npm@ can review this one?
> 
> What's with the core/fxcrt/include/#cfx_weak_ptr.h# file?
Stray, removed.

[Tom Sepez, 2016-09-23 02:06:29]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:17:43]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-23 14:25:44]

lgtm

[npm, 2016-09-23 14:26:10]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-09-23 14:26:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 14:26:32]

Description was changed from

==========
Make CPDF_Font::Create() return a std::unique_ptr.
==========

to

==========
Make CPDF_Font::Create() return a std::unique_ptr.

Committed:
https://pdfium.googlesource.com/pdfium/+/3f4111fbff1233de9f5c67eda433bee0f5f8...
==========

[commit-bot: I haz the power, 2016-09-23 14:26:33]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3f4111fbff1233de9f5c67eda433bee0f5f8...