Lock down the registration of blob:chrome-extension:// URLs

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 202 matching lines @@
   print_job_manager_.reset(new printing::PrintJobManager);
 #endif
 
   base::FilePath net_log_path;
   if (command_line.HasSwitch(switches::kLogNetLog))
     net_log_path = command_line.GetSwitchValuePath(switches::kLogNetLog);
   net_log_.reset(new net_log::ChromeNetLog(
       net_log_path, GetNetCaptureModeFromCommandLine(command_line),
       command_line.GetCommandLineString(), chrome::GetChannelString()));
 
-  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
+  // chrome-extension:// URLs are safe to request anywhere, but may only
+  // commit (including in iframes) in extension processes.

[Charlie Reis, 2016/09/28 22:07:16]

Sanity check: Will this affect DevTools extensions?

[ncarter (slow), 2016/09/29 21:01:45]

Excellent catch. This was a real bug; I've fixed it and added a test.

+  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeIsolatedScheme(
       extensions::kExtensionScheme);
-  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
+  // TODO(nick): Kill off kExtensionResourceScheme.
+  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeIsolatedScheme(
       extensions::kExtensionResourceScheme);
   ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
       chrome::kChromeSearchScheme);
 
 #if defined(OS_MACOSX)
   ui::InitIdleMonitor();
 #endif
 
   device_client_.reset(new ChromeDeviceClient);
 
@@ skipping 1109 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)