color: Set GpuMemoryBuffer color spaces for Canvas

color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df
Cr-Commit-Position: refs/heads/master@{#422167}

[ccameron, 2016-09-22 23:21:26]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:26:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-22 23:46:48]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:47:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-22 23:49:05]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 00:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 00:09:39]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[ccameron, 2016-09-23 01:06:05]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:29:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-09-27 18:13:55]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:14:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-27 18:36:11]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2016-09-27 18:36:32]

Patchset #4 (id:60001) has been deleted

[ccameron, 2016-09-27 18:36:39]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-09-27 18:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-27 18:36:50]

Patchset #2 (id:20001) has been deleted

[ccameron, 2016-09-27 18:57:04]

Description was changed from

==========
color: Set GpuMemoryBuffer color spaces for ...

BUG=
==========

to

==========
color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
==========

[ccameron, 2016-09-27 18:57:04]

ccameron@chromium.org changed reviewers:
+ jbroman@chromium.org, junov@chromium.org

[ccameron, 2016-09-27 19:53:14]

Adding jbroman for platform/ API changes

Adding junov for Canvas2DLayerBridge changes.

I think there's quite a lot of room for refactoring of Canvas2DLayerBridge to be
more precise about lifetimes (and also in the similar DrawingBuffer). I made an
effort to keep this patch limited in scope -- that refactor can follow (without
functional changes).

https://codereview.chromium.org/2364633003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h (right):

https://codereview.chromium.org/2364633003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h:174:
RefPtr<ImageInfo> m_imageInfo;
This could reasonably be expected to be a std::unique_ptr, but that will involve
refactoring all instances of MailboxInfo to also be move-correct (and likely
std::unique_ptr as well).

[commit-bot: I haz the power, 2016-09-27 20:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:19:11]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Justin Novosad, 2016-09-28 15:28:07]

lgtm for Canvas2DLayerBridge

+1 to refactor ownership model in follow-up CL.

[ccameron, 2016-09-28 17:31:04]

Description was changed from

==========
color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
==========

to

==========
color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-09-28 17:31:07]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 17:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:28:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ccameron, 2016-09-28 19:16:26]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org

[ccameron, 2016-09-28 19:16:27]

Adding dcheng@ for gpu/ipc/common
Adding avi@ for content/

https://codereview.chromium.org/2364633003/diff/100001/gpu/ipc/common/surface...
File gpu/ipc/common/surface_handle.h (right):

https://codereview.chromium.org/2364633003/diff/100001/gpu/ipc/common/surface...
gpu/ipc/common/surface_handle.h:33: const SurfaceHandle kNullSurfaceHandle =
NULL;
win-clang doesn't allow this definition in a header (breaks when included via
gpu_memory_manager.h):

https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds...

This preserves the same defintion as gfx::kNullAcceleratedWidget.

[dcheng, 2016-09-28 20:32:43]

https://codereview.chromium.org/2364633003/diff/100001/gpu/ipc/common/surface...
File gpu/ipc/common/surface_handle.h (right):

https://codereview.chromium.org/2364633003/diff/100001/gpu/ipc/common/surface...
gpu/ipc/common/surface_handle.h:33: const SurfaceHandle kNullSurfaceHandle =
NULL;
On 2016/09/28 19:16:27, ccameron wrote:
> win-clang doesn't allow this definition in a header (breaks when included via
> gpu_memory_manager.h):
> 
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds...
> 
> This preserves the same defintion as gfx::kNullAcceleratedWidget.

Can we just make it a constexpr? That should get rid of the global constructor
issue, I think.

[Avi (use Gerrit), 2016-09-28 20:49:58]

lgtm

content stampity stamp

[ccameron, 2016-09-29 01:17:39]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 01:17:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 02:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 02:48:02]

Dry run: Exceeded global retry quota

[jbroman, 2016-09-29 14:38:48]

public/platform/ API changes lgtm, but you'll need an actual owner of it to land

[ccameron, 2016-09-29 19:17:26]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 19:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-29 20:47:53]

dcheng, thanks!

TIL about constexpr (and fell deeper into my "I don't know C++ anymore" pit of
despair).

https://codereview.chromium.org/2364633003/diff/140001/gpu/ipc/common/surface...
File gpu/ipc/common/surface_handle.h (right):

https://codereview.chromium.org/2364633003/diff/140001/gpu/ipc/common/surface...
gpu/ipc/common/surface_handle.h:32: constexpr SurfaceHandle kNullSurfaceHandle =
gfx::kNullAcceleratedWidget;
This is not strictly necessary, but it'll be needed if anyone wants to use
gpu::kNullSurfaceHandle in the way that we use gfx::NullAcceleratedWidget here.

[commit-bot: I haz the power, 2016-09-29 20:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:58:16]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-09-30 06:37:47]

constexpr and public/platform LGTM

[ccameron, 2016-09-30 18:49:55]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-09-30 18:49:56]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org,
avi@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2364633003/#ps140001
(title: "Fix constexpr")

[commit-bot: I haz the power, 2016-09-30 18:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 18:59:05]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-09-30 19:03:52]

Description was changed from

==========
color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG=632178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df
Cr-Commit-Position: refs/heads/master@{#422167}
==========

[commit-bot: I haz the power, 2016-09-30 19:03:53]

Patchset 5 (id:??) landed as
https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df
Cr-Commit-Position: refs/heads/master@{#422167}