Issue 23646007: Fix bug in SkWriter32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23646007: Fix bug in SkWriter32. (Closed)

Created:
7 years, 3 months ago by mtklein

Modified:
7 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix bug in SkWriter32. If you give SkWriter32 external storage but that external storage is too small for the first reservation you make, you'll hit an assert in debug mode. I think the answer is to simply remove the SkASSERT. Added a test. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11062

Patch Set 1 #

Patch Set 2 : tweak #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/core/SkWriter32.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/Writer32Test.cpp	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein

7 years, 3 months ago (2013-09-03 18:07:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r11062 (presubmit successful).

Expand Messages | Collapse Messages