Issue 23646006: gtk: Split CustomDrag into multiple pieces.

Issue 23646006: gtk: Split CustomDrag into multiple pieces. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
asanka, benjhayden, Elliot Glaysher

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gtk: Split CustomDrag into multiple pieces. This will make it easier the next patch in this series. BUG=None TEST=None, no functional change, just refactoring. R=asanka@chromium.org, erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220705

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fixes #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -317 lines)			Patch
M	chrome/browser/download/drag_download_item_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/ui/gtk/bookmarks/bookmark_drag.h	View		1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/bookmarks/bookmark_drag.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_drag_drop_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/custom_drag.h	View	1	3 chunks	+4 lines, -64 lines	0 comments	Download
M	chrome/browser/ui/gtk/custom_drag.cc	View	1 2	2 chunks	+0 lines, -150 lines	0 comments	Download
A	chrome/browser/ui/gtk/download/download_item_drag.h	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/gtk/download/download_item_drag.cc	View	1 2	5 chunks	+39 lines, -100 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_item_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

asanka

LGTM for c/b/download Just curious: Are you planning on moving drag_download_item_gtk contents into ../gtk/../download_item_drag ?

7 years, 3 months ago (2013-08-30 15:55:47 UTC) #2

tfarina

Committed patchset #3 manually as r220705 (presubmit successful).

7 years, 3 months ago (2013-08-31 00:20:08 UTC) #4

tfarina

On 2013/08/30 15:55:47, asanka wrote: > LGTM for c/b/download > > Just curious: Are you ...

7 years, 3 months ago (2013-08-31 18:40:44 UTC) #5

asanka

7 years, 3 months ago (2013-09-03 13:40:27 UTC) #6

Message was sent while issue was closed.

On 2013/08/31 18:40:44, tfarina wrote:
> On 2013/08/30 15:55:47, asanka wrote:
> > LGTM for c/b/download
> > 
> > Just curious: Are you planning on moving drag_download_item_gtk contents
into
> > ../gtk/../download_item_drag ?
> 
> Oh, I see, like download_item_drag_mac.mm. Yeah, I'll do.

Yup. Thanks.

Expand Messages | Collapse Messages