Source/core/platform/image-decoders/gif/GIFImageDecoder.h - Issue 23646005: Improve GIF decoding performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/image-decoders/gif/GIFImageDecoder.h

Issue 23646005: Improve GIF decoding performance (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: test with bad code Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp » ('j') | Source/core/platform/image-decoders/gif/GIFImageDecoderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/image-decoders/gif/GIFImageDecoder.h

diff --git a/Source/core/platform/image-decoders/gif/GIFImageDecoder.h b/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

index 3159b7bedbce1961c0d067d466ea672369d7eacd..d3b7061780818f3a7228eac1321cb8d06ec9ff8d 100644

--- a/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

+++ b/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

@@ -31,6 +31,8 @@

class GIFImageReader;

+typedef Vector<unsigned char> GIFRow;

namespace WebCore {

// This class decodes the GIF image format.

@@ -57,7 +59,7 @@ namespace WebCore {

virtual bool setFailed() OVERRIDE;

// Callbacks from the GIF reader.

- bool haveDecodedRow(size_t frameIndex, const Vector<unsigned char>& rowBuffer, size_t width, size_t rowNumber, unsigned repeatCount, bool writeTransparentPixels);

+ bool haveDecodedRow(size_t frameIndex, GIFRow::const_iterator rowBegin, size_t width, size_t rowNumber, unsigned repeatCount, bool writeTransparentPixels);

bool frameComplete(size_t frameIndex);

// For testing.