Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2364593002: Re-enable tests under mac-asan. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
index f2227688598bbec2292fffeaa88b19990f65f44a..54c16575890185cd7389376677a7e80d121a6917 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -109,13 +109,7 @@ private:
bool m_finished;
};
-#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
-// TODO(marja): Fix this test, http://crbug.com/572987
-#define MAYBE_CompilingStreamedScript DISABLED_CompilingStreamedScript
-#else
-#define MAYBE_CompilingStreamedScript CompilingStreamedScript
-#endif
-TEST_F(ScriptStreamingTest, MAYBE_CompilingStreamedScript)
+TEST_F(ScriptStreamingTest, CompilingStreamedScript)
{
// Test that we can successfully compile a streamed script.
V8TestingScope scope;
@@ -284,13 +278,7 @@ TEST_F(ScriptStreamingTest, SmallScripts)
EXPECT_FALSE(sourceCode.streamer());
}
-#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
-// TODO(marja): Fix this test, http://crbug.com/572987
-#define MAYBE_ScriptsWithSmallFirstChunk DISABLED_ScriptsWithSmallFirstChunk
-#else
-#define MAYBE_ScriptsWithSmallFirstChunk ScriptsWithSmallFirstChunk
-#endif
-TEST_F(ScriptStreamingTest, MAYBE_ScriptsWithSmallFirstChunk)
+TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk)
{
// If a script is long enough, if should be streamed, even if the first data
// chunk is small.
@@ -321,13 +309,7 @@ TEST_F(ScriptStreamingTest, MAYBE_ScriptsWithSmallFirstChunk)
EXPECT_FALSE(tryCatch.HasCaught());
}
-#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
-// TODO(marja): Fix this test, http://crbug.com/572987
-#define MAYBE_EncodingChanges DISABLED_EncodingChanges
-#else
-#define MAYBE_EncodingChanges EncodingChanges
-#endif
-TEST_F(ScriptStreamingTest, MAYBE_EncodingChanges)
+TEST_F(ScriptStreamingTest, EncodingChanges)
{
// It's possible that the encoding of the Resource changes after we start
// loading it.
@@ -357,13 +339,7 @@ TEST_F(ScriptStreamingTest, MAYBE_EncodingChanges)
}
-#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
-// TODO(marja): Fix this test, http://crbug.com/572987
-#define MAYBE_EncodingFromBOM DISABLED_EncodingFromBOM
-#else
-#define MAYBE_EncodingFromBOM EncodingFromBOM
-#endif
-TEST_F(ScriptStreamingTest, MAYBE_EncodingFromBOM)
+TEST_F(ScriptStreamingTest, EncodingFromBOM)
{
// Byte order marks should be removed before giving the data to V8. They
// will also affect encoding detection.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698