Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2364593002:
Re-enable tests under mac-asan. (Closed)
DescriptionRe-enable tests under mac-asan.
I never quite found what the original issues were, but apparently they've been fixed in the mean time.
Revert "Disable faiilng tests under mac/asan"
This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f.
BUG=572987
Committed: https://crrev.com/aefd0f63cf06db37e1e2e71f1c2bbcff80c49bd9
Cr-Commit-Position: refs/heads/master@{#420606}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
The CQ bit was unchecked by vogelheim@chromium.org
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ========== to ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ==========
vogelheim@chromium.org changed reviewers: + marja@chromium.org
Description was changed from ========== Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ========== to ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ==========
vogelheim@chromium.org changed reviewers: + marja@chromium.org
ptal
lgtm - thanks for looking into this!
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ========== to ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= ========== to ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= Committed: https://crrev.com/aefd0f63cf06db37e1e2e71f1c2bbcff80c49bd9 Cr-Commit-Position: refs/heads/master@{#420606} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/aefd0f63cf06db37e1e2e71f1c2bbcff80c49bd9 Cr-Commit-Position: refs/heads/master@{#420606}
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG= Committed: https://crrev.com/aefd0f63cf06db37e1e2e71f1c2bbcff80c49bd9 Cr-Commit-Position: refs/heads/master@{#420606} ========== to ========== Re-enable tests under mac-asan. I never quite found what the original issues were, but apparently they've been fixed in the mean time. Revert "Disable faiilng tests under mac/asan" This reverts commit 6585cde1e517b73a9a44572aecce1eebaa46d92f. BUG=572987 Committed: https://crrev.com/aefd0f63cf06db37e1e2e71f1c2bbcff80c49bd9 Cr-Commit-Position: refs/heads/master@{#420606} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
