Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2364583002: cc: Add edge case test in spiral iterator unittest. (Closed)

Created:
4 years, 2 months ago by prashant.n
Modified:
4 years, 2 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add edge case test in spiral iterator unittest. Add edge case when tiling is smaller than tile size and center rect is not intersecting to tiling rect. In this around index and consider index point to the same index and as center rect is not intersecting, it lies below the tiling rect as shown below. Double line box represents the tile size, T represents tiling and * represents center rect. ┌───┬══════╗ │ T │ ║ ├───┘┌───┐ ║ ║ │ * │ ║ ║ └───┘ ║ ╚══════════╝ In this case, spiral iterator should return tile at (0, 0) as a valid tile. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/4776477be73a1ff287bba2e17ee4963ceecf82a0 Cr-Commit-Position: refs/heads/master@{#420824}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M cc/base/spiral_iterator_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
prashant.n
ptal. While working on pyramid sequence (PS), many unit tests written for spiral iterator helped ...
4 years, 2 months ago (2016-09-22 13:38:19 UTC) #3
vmpstr
lgtm
4 years, 2 months ago (2016-09-23 21:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364583002/20001
4 years, 2 months ago (2016-09-24 04:03:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-24 04:17:06 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-24 04:19:02 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4776477be73a1ff287bba2e17ee4963ceecf82a0
Cr-Commit-Position: refs/heads/master@{#420824}

Powered by Google App Engine
This is Rietveld 408576698