Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2364523003: Revert of Generating autocomplete results with and without word breaks in the Omnibox. (Closed)

Created:
4 years, 3 months ago by Mark P
Modified:
4 years, 3 months ago
Reviewers:
Lavar Askew
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generating autocomplete results with and without word breaks in the Omnibox. (patchset #13 id:240001 of https://codereview.chromium.org/2187343002/ ) Reason for revert: Reverting. Will be replaced by cleaner implementation: https://codereview.chromium.org/2363463002/ --mark Original issue's description: > Generating autocomplete results with and without word breaks in the Omnibox. > > The goal is to support mid-word autocomplete in the Omnibox. Currently, if the user types "funtimes", inserts the cursor between the "n" and the "t" and begins typing the word "good" the Ominbox will search for URL results that match "fungood times" only. We want to also search for "fungoodtimes". > > BUG=591979 > TEST=0. Clear browser history. > 1. Visit the following link: https://twitter.com/fungoodtimes > 2. Open a new browser tab. > 3.Type into the Omnibox "funtimes". Note the lack of the suggestion for the above URL. > 4. Insert the cursor between the "n" and "t" in "funtime" and type "good". > 5. The above URL should show in the autocomplete list. > > Committed: https://crrev.com/e3235816f23e9eb733d11bdecdfd5f8ca67cec9f > Cr-Commit-Position: refs/heads/master@{#418054} TBR=open.hyperion@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591979 Committed: https://crrev.com/1a30ef7b27c9c4b3d0df1ff7eb93cb3d506d35b1 Cr-Commit-Position: refs/heads/master@{#420521}

Patch Set 1 #

Patch Set 2 : revert using git, then upload patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -146 lines) Patch
M AUTHORS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox/browser/history_quick_provider_unittest.cc View 1 2 chunks +46 lines, -57 lines 0 comments Download
M components/omnibox/browser/url_index_private_data.h View 1 1 chunk +13 lines, -12 lines 0 comments Download
M components/omnibox/browser/url_index_private_data.cc View 1 6 chunks +17 lines, -76 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Mark P
Created Revert of Generating autocomplete results with and without word breaks in the Omnibox.
4 years, 3 months ago (2016-09-22 17:19:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364523003/1
4 years, 3 months ago (2016-09-22 17:19:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/133306) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-09-22 17:23:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364523003/90001
4 years, 3 months ago (2016-09-22 23:28:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 3 months ago (2016-09-23 01:04:59 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:08:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a30ef7b27c9c4b3d0df1ff7eb93cb3d506d35b1
Cr-Commit-Position: refs/heads/master@{#420521}

Powered by Google App Engine
This is Rietveld 408576698