Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/callback_registry.h.pump

Issue 23645019: C++ Readability Review for caitkp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/callback_registry.h ('K') | « base/callback_registry.h ('k') | base/callback_registry_unittest.cc » ('j') | base/callback_registry_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/callback_registry.h.pump
diff --git a/base/callback_registry.h.pump b/base/callback_registry.h.pump
index fff1dc89e7bf8aad4a820d99d83813b7a78ff2ee..d3a004ac161d13447839d42a48a16a6dcac554bd 100644
--- a/base/callback_registry.h.pump
+++ b/base/callback_registry.h.pump
@@ -70,7 +70,8 @@ $var MAX_ARITY = 7
// // Do something.
// }
//
-// scoped_ptr<base::CallbackRegistry<Foo>::Subscription> foo_subscription_;
+// scoped_ptr<base::CallbackRegistry<void(const Foo&)>::Subscription>
+// foo_subscription_;
// };
namespace base {
@@ -241,3 +242,4 @@ $if ARITY == 0 [[
} // namespace base
#endif // BASE_CALLBACK_REGISTRY_H
+// NOSUBMIT: Force git to add file for readability.
« base/callback_registry.h ('K') | « base/callback_registry.h ('k') | base/callback_registry_unittest.cc » ('j') | base/callback_registry_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698