C++ Readability Review for caitkp

base/callback_registry_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback_registry.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace {
 
 class Listener {
  public:
   Listener() : total_(0), scaler_(1) {}
   explicit Listener(int scaler) : total_(0), scaler_(scaler) {}
   void IncrementTotal() { total_++; }
   void IncrementByMultipleOfScaler(int x) { total_ += x * scaler_; }
 
   int total_;

[milos, 2013/10/01 17:54:21]

In general all data members should be private, see
https://www.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml#Access_Control

[Cait (Slow), 2013/10/01 22:51:27]

Done.

 
  private:
   int scaler_;
   DISALLOW_COPY_AND_ASSIGN(Listener);
 };
 
 class Remover {
  public:
   Remover() : total_(0) {}
   void IncrementTotalAndRemove() {
@@ skipping 241 matching lines @@
 
 // Sanity check: notifying an empty list is a no-op.
 TEST(CallbackRegistryTest, EmptyList) {
   CallbackRegistry<void(void)> cb_reg;
 
   cb_reg.Notify();
 }
 
 }  // namespace
 }  // namespace base
+// NOSUBMIT: Force git to add file for readability.