C++ Readability Review for caitkp

base/callback_list.h

 // This file was GENERATED by command:
 //     pump.py callback_list.h.pump
 // DO NOT EDIT BY HAND!!!
 
 
 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_CALLBACK_LIST_H_
@@ skipping 27 matching lines @@
 //   RegisterCallback(const OnFooCallback& cb) {
 //     return callback_list_.Add(cb);
 //   }
 //
 //  private:
 //   void NotifyFoo(const Foo& foo) {
 //      callback_list_.Notify(foo);
 //   }
 //
 //   base::CallbackList<void(const Foo&)> callback_list_;
+//
+//   DISALLOW_COPY_AND_ASSIGN(MyWidget);
 // };
 //
 //
 // class MyWidgetListener {
 //  public:
 //   MyWidgetListener::MyWidgetListener() {
 //     foo_subscription_ = MyWidget::GetCurrent()->RegisterCallback(
 //             base::Bind(&MyWidgetListener::OnFoo, this)));
 //   }
 //
 //   MyWidgetListener::~MyWidgetListener() {
 //      // Subscription gets deleted automatically and will deregister
 //      // the callback in the process.
 //   }
 //
 //  private:
 //   void OnFoo(const Foo& foo) {
 //     // Do something.
 //   }
 //
 //   scoped_ptr<base::CallbackList<void(const Foo&)>::Subscription>
 //       foo_subscription_;
+//
+//   DISALLOW_COPY_AND_ASSIGN(MyWidgetListener);
 // };
 
 namespace base {
 
 namespace internal {
 
 template <typename CallbackType>
 class CallbackListBase {
  public:
   class Subscription {
    public:
     Subscription(CallbackListBase<CallbackType>* list,
                  typename std::list<CallbackType>::iterator iter)
         : list_(list),
-          iter_(iter) {}
+          iter_(iter) {
+    }
 
     ~Subscription() {
       if (list_->active_iterator_count_)
-        (*iter_).Reset();
+        iter_->Reset();
       else
         list_->callbacks_.erase(iter_);
     }
 
    private:
     CallbackListBase<CallbackType>* list_;
     typename std::list<CallbackType>::iterator iter_;
 
     DISALLOW_COPY_AND_ASSIGN(Subscription);
   };
@@ skipping 39 matching lines @@
         ++list_iter_;
       }
       return cb;
     }
 
    private:
     CallbackListBase<CallbackType>* list_;
     typename std::list<CallbackType>::iterator list_iter_;
   };
 
-  CallbackListBase()
-      : active_iterator_count_(0) {}
+  CallbackListBase() : active_iterator_count_(0) {}
 
   ~CallbackListBase() {
     DCHECK_EQ(0, active_iterator_count_);
     DCHECK_EQ(0U, callbacks_.size());
   }
 
   // Returns an instance of a CallbackListBase::Iterator which can be used
   // to run callbacks.
   Iterator GetIterator() {
     return Iterator(this);
@@ skipping 39 matching lines @@
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CallbackList);
 };
 
 template <typename A1>
 class CallbackList<void(A1)>
     : public internal::CallbackListBase<
         Callback<void(A1)> > {

[milos, 2013/10/03 15:49:43]

This would fit on the previous line, so it would be preferred.

[Cait (Slow), 2013/10/03 15:58:11]

Done.

  public:
   typedef Callback<void(A1)> CallbackType;
 
   CallbackList() {}
 
   void Notify(typename internal::CallbackParamTraits<A1>::ForwardType a1) {
     typename internal::CallbackListBase<CallbackType>::Iterator it =
         this->GetIterator();
     CallbackType* cb;
     while((cb = it.GetNext()) != NULL) {

[milos, 2013/10/03 15:49:43]

Missing a space between "while" and "("

[Cait (Slow), 2013/10/03 15:58:11]

Done.

       cb->Run(a1);
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CallbackList);
 };
 
 template <typename A1, typename A2>
 class CallbackList<void(A1, A2)>
     : public internal::CallbackListBase<
         Callback<void(A1, A2)> > {

[milos, 2013/10/03 15:49:43]

Ditto

[Cait (Slow), 2013/10/03 15:58:11]

Done.

  public:
   typedef Callback<void(A1, A2)> CallbackType;
 
   CallbackList() {}
 
   void Notify(typename internal::CallbackParamTraits<A1>::ForwardType a1,
               typename internal::CallbackParamTraits<A2>::ForwardType a2) {
     typename internal::CallbackListBase<CallbackType>::Iterator it =
         this->GetIterator();
     CallbackType* cb;
     while((cb = it.GetNext()) != NULL) {

[milos, 2013/10/03 15:49:43]

Ditto

[Cait (Slow), 2013/10/03 15:58:11]

Done.

       cb->Run(a1, a2);
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CallbackList);
 };
 
 template <typename A1, typename A2, typename A3>
 class CallbackList<void(A1, A2, A3)>
@@ skipping 123 matching lines @@
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CallbackList);
 };
 
 }  // namespace base
 
 #endif  // BASE_CALLBACK_LIST_H_