runtime/vm/intrinsifier_x64.cc - Issue 23645003: Esoteric bit operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 23645003: Esoteric bit operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_x64.cc

diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc

index 8b2353287b407844ccbe39fd69a761d1bcb2f5c0..dc647ac794e80f5de5b88e4b9f7cc36a41ff2a38 100644

--- a/runtime/vm/intrinsifier_x64.cc

+++ b/runtime/vm/intrinsifier_x64.cc

@@ -1004,6 +1004,11 @@ void Intrinsifier::Smi_bitNegate(Assembler* assembler) {

}

+void Intrinsifier::Smi_bitLength(Assembler* assembler) {

+ // TODO(sra): Implement using bsrq.

// Check if the last argument is a double, jump to label 'is_smi' if smi

// (easy to convert to double), otherwise jump to label 'not_double_smi',

// Returns the last argument in RAX.

« no previous file with comments | « runtime/vm/intrinsifier_mips.cc ('k') | sdk/lib/_internal/lib/js_number.dart » ('j') | no next file with comments »