Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 23644002: MIPS: Eliminate intentional conversion from Smi to Int32 in HMul (Closed)

Created:
7 years, 3 months ago by palfia
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Eliminate intentional conversion from Smi to Int32 in HMul Port r16361 (b41ab14c) Original commit message: If not all uses of arithmetic binary operation can be truncated to Smi, check if they can be truncated to Int32 which could avoid minus zero check Fixed DoMulI on X64 to adopt correct operand size when the representation is Smi Fixed DoMulI on ARM. Constant right operand optimization is based on Integer 32 instead of its representation. BUG= Committed: https://code.google.com/p/v8/source/detail?r=16374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 3 months ago (2013-08-27 21:42:51 UTC) #1
Paul Lind
LGTM.
7 years, 3 months ago (2013-08-27 23:01:15 UTC) #2
palfia
7 years, 3 months ago (2013-08-27 23:05:15 UTC) #3
Message was sent while issue was closed.
Committed manually as r16374.

Powered by Google App Engine
This is Rietveld 408576698