assert_*d_matrix_equals fuction can accept array as expected parameter.

assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None

Committed: https://crrev.com/c7a688377217a7a7fa65a4ace691a471e16c0231
Cr-Commit-Position: refs/heads/master@{#420857}

[Hwanseung Lee, 2016-09-25 04:03:16]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

it makes more simply test code.

BUG= None
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG= None
==========

[Hwanseung Lee, 2016-09-25 04:03:33]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[Hwanseung Lee, 2016-09-25 04:03:54]

@zino PTAL, thank you.

[zino, 2016-09-25 08:30:55]

https://codereview.chromium.org/2364393002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
(right):

https://codereview.chromium.org/2364393002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:22:
var isArrayExected = Array.isArray(expected);
Let's simplify as follows. (It's not perfect yet but you can polish it)

function assert_2d_matrix_equals(actual, expected, description) {
    if (Array.isArray(expected)) {
        assert_equals(6, expected_length);
        assert_matrix_equals(actual, { ... });
    } else {
        expected['is2D'] = false;
        expected['isIdentity'] = false;
        assert_matrix_equals(actual, expected);
    }
}

[Hwanseung Lee, 2016-09-25 08:56:05]

@zino could you review again?

https://codereview.chromium.org/2364393002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
(right):

https://codereview.chromium.org/2364393002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:22:
var isArrayExected = Array.isArray(expected);
On 2016/09/25 08:30:54, zino wrote:
> Let's simplify as follows. (It's not perfect yet but you can polish it)
> 
> function assert_2d_matrix_equals(actual, expected, description) {
>     if (Array.isArray(expected)) {
>         assert_equals(6, expected_length);
>         assert_matrix_equals(actual, { ... });
>     } else {
>         expected['is2D'] = false;
>         expected['isIdentity'] = false;
>         assert_matrix_equals(actual, expected);
>     }
> }

Done.

[zino, 2016-09-25 09:02:47]

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
(right):

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:38:
is2D: true, isIdentity: expected.isIdentity
I think isIdentity should always be false. (Because there is already the
assert_idenity_2d_matrix()).

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:57:
assert_matrix_equals(actual, expected, description);
ditto

[Hwanseung Lee, 2016-09-25 09:08:59]

@zino.
could you review again? thank you.

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
(right):

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:38:
is2D: true, isIdentity: expected.isIdentity
On 2016/09/25 09:02:47, zino wrote:
> I think isIdentity should always be false. (Because there is already the
> assert_idenity_2d_matrix()).

Done.

https://codereview.chromium.org/2364393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js:57:
assert_matrix_equals(actual, expected, description);
On 2016/09/25 09:02:47, zino wrote:
> ditto

Done.

[zino, 2016-09-25 09:25:25]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-25 09:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2016-09-25 09:44:48]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-25 09:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-25 10:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-25 10:48:18]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2016-09-25 10:49:52]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-25 10:49:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-25 10:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-25 10:50:00]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[zino, 2016-09-25 11:52:41]

lgtm

[Hwanseung Lee, 2016-09-25 11:57:19]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-25 11:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2016-09-25 12:00:23]

The CQ bit was unchecked by jinho.bang@samsung.com

[zino, 2016-09-25 12:03:32]

On 2016/09/25 11:57:29, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Please update CL description. BUG=none (unnecessary blank)

[Hwanseung Lee, 2016-09-25 12:04:54]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG= None
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=
==========

[Hwanseung Lee, 2016-09-25 12:05:18]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.
==========

[Hwanseung Lee, 2016-09-25 12:08:35]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

Bug=None
==========

[Hwanseung Lee, 2016-09-25 12:08:46]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

Bug=None
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None
==========

[Hwanseung Lee, 2016-09-25 12:09:12]

On 2016/09/25 12:03:32, zino wrote:
> On 2016/09/25 11:57:29, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Please update CL description. BUG=none (unnecessary blank)

i fix a Cl description.

[Hwanseung Lee, 2016-09-25 12:10:09]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-25 12:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-25 12:16:15]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None
==========

[commit-bot: I haz the power, 2016-09-25 12:16:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-25 12:18:50]

Description was changed from

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None
==========

to

==========
assert_*d_matrix_equals fuction can accept array as expected parameter.

when use it, it makes more simple test code.

BUG=None

Committed: https://crrev.com/c7a688377217a7a7fa65a4ace691a471e16c0231
Cr-Commit-Position: refs/heads/master@{#420857}
==========

[commit-bot: I haz the power, 2016-09-25 12:18:51]

Patchset 4 (id:??) landed as
https://crrev.com/c7a688377217a7a7fa65a4ace691a471e16c0231
Cr-Commit-Position: refs/heads/master@{#420857}