Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2364383002: Preformat UseCounter.h to avoid clang-format confusing the UMA scripts. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preformat UseCounter.h to avoid clang-format confusing the UMA scripts. There are a number of python scripts that parse this file and expect lines to be formatted a certain way. If a line is too long, clang-format will wrap it and break the format that the python script is expecting. BUG=649969 Committed: https://crrev.com/1817af69e71e157c64e2961839a5c9ba45dbaca2 Cr-Commit-Position: refs/heads/master@{#420858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-09-25 02:11:18 UTC) #2
Nico
lgtm
4 years, 2 months ago (2016-09-25 12:57:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364383002/1
4 years, 2 months ago (2016-09-25 12:58:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-25 13:03:23 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-25 13:06:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1817af69e71e157c64e2961839a5c9ba45dbaca2
Cr-Commit-Position: refs/heads/master@{#420858}

Powered by Google App Engine
This is Rietveld 408576698