[chromedriver] Load the automation extension as a component extension.

chrome/test/chromedriver/chrome_launcher.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome_launcher.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 502 matching lines @@
     extension_paths.push_back(path.value());
     if (bg_page.length())
       bg_pages_tmp.push_back(bg_page);
   }
 
   if (include_automation_extension) {
     base::FilePath automation_extension;
     Status status = UnpackAutomationExtension(temp_dir, &automation_extension);
     if (status.IsError())
       return status;
-    if (command->HasSwitch("disable-extensions")) {
-      command->AppendSwitchNative("load-component-extension",
-                                  automation_extension.value());
-    } else {
-      extension_paths.push_back(automation_extension.value());
-    }
+    command->AppendSwitchNative("load-component-extension",

[chrisgao (Use stgao instead), 2013/08/28 17:01:58]

If the users pass in an argument "--load-component-extension=path", it fails
like the current case in the bug.
I remember there was a crash if use "load-component-extension" without
"disable-extensions", although not 100% sure which version of chrome it was.

How about doing it this way?
If "load-component-extension" is passed in, we update its value instead of
adding a switch with the same name.

+                                automation_extension.value());
   }
 
   if (extension_paths.size()) {
     base::FilePath::StringType extension_paths_value = JoinString(
         extension_paths, FILE_PATH_LITERAL(','));
     command->AppendSwitchNative("load-extension", extension_paths_value);
   }
   bg_pages->swap(bg_pages_tmp);
   return Status(kOk);
 }
@@ skipping 53 matching lines @@
   // Write empty "First Run" file, otherwise Chrome will wipe the default
   // profile that was written.
   if (file_util::WriteFile(
           user_data_dir.AppendASCII("First Run"), "", 0) != 0) {
     return Status(kUnknownError, "failed to write first run file");
   }
   return Status(kOk);
 }
 
 }  // namespace internal