Enable invalidations for arbitrary objects on Android.

sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java

Index: sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java
diff --git a/sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java b/sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java
index 215430b9a5203e94b4ef78d5b0bc84f249dda4ad..2b28a59779baef93ddbe500686cae1b2020af414 100644
--- a/sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java
+++ b/sync/android/javatests/src/org/chromium/sync/notifier/InvalidationControllerTest.java
@@ -13,6 +13,8 @@ import android.content.pm.PackageManager;
 import android.test.InstrumentationTestCase;
 import android.test.suitebuilder.annotation.SmallTest;
 
+import com.google.ipc.invalidation.external.client.types.ObjectId;
+
 import org.chromium.base.ActivityStatus;
 import org.chromium.base.CollectionUtil;
 import org.chromium.base.test.util.AdvancedMockContext;
@@ -171,6 +173,7 @@ public class InvalidationControllerTest extends InstrumentationTestCase {
         Set<String> actualTypes = new HashSet<String>();
         actualTypes.addAll(intent.getStringArrayListExtra(IntentProtocol.EXTRA_REGISTERED_TYPES));
         assertEquals(expectedTypes, actualTypes);
+        assertNull(IntentProtocol.getRegisteredObjectIds(intent));
     }
 
     @SmallTest
@@ -195,6 +198,7 @@ public class InvalidationControllerTest extends InstrumentationTestCase {
         Set<String> actualTypes = new HashSet<String>();
         actualTypes.addAll(intent.getStringArrayListExtra(IntentProtocol.EXTRA_REGISTERED_TYPES));
         assertEquals(expectedTypes, actualTypes);
+        assertNull(IntentProtocol.getRegisteredObjectIds(intent));
     }
 
     @SmallTest
@@ -277,6 +281,26 @@ public class InvalidationControllerTest extends InstrumentationTestCase {
         assertEquals(true, resultAllTypes.get());
     }
 
+    @SmallTest
+    @Feature({"Sync"})
+    public void testSetRegisteredObjectIds() {
+      InvalidationController controller = new InvalidationController(mContext);

[nyquist, 2013/09/05 22:50:08]

Nit: Indent should be 4.

[Steve Condie, 2013/09/06 20:05:22]

Done.

+      controller.setRegisteredObjectIds(new int[] { 1, 2 }, new String[] { "a", "b" });

[nyquist, 2013/09/05 22:50:08]

Nit:
controller.setRegisteredObjectIds(new int[] {1, 2}, new String[] {"a", "b"});

[Steve Condie, 2013/09/06 20:05:22]

Done.

+      assertEquals(1, mContext.getNumStartedIntents());
+
+      // Validate destination.
+      Intent intent = mContext.getStartedIntent(0);
+      validateIntentComponent(intent);
+      assertEquals(IntentProtocol.ACTION_REGISTER, intent.getAction());
+
+      // Validate registered object ids.
+      assertNull(intent.getStringArrayListExtra(IntentProtocol.EXTRA_REGISTERED_TYPES));
+      Set<ObjectId> objectIds = IntentProtocol.getRegisteredObjectIds(intent);
+      assertEquals(2, objectIds.size());
+      assertTrue(objectIds.contains(ObjectId.newInstance(1, "a".getBytes())));
+      assertTrue(objectIds.contains(ObjectId.newInstance(2, "b".getBytes())));
+    }
+
     /**
      * Asserts that {@code intent} is destined for the correct component.
      */