Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2364293002: ShortToHalfFloat_AVX2 function (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Reviewers:
wangcheng, hubbe1
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add header define and prototype #

Patch Set 3 : git cl try #

Patch Set 4 : renamed to F16 and moved into windows only section #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M include/libyuv/row.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M source/row_win.cc View 1 2 3 1 chunk +30 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
wangcheng
Overall, this change LGTM. One possible improvement is to unroll the loop to further improve ...
4 years, 2 months ago (2016-09-27 17:35:52 UTC) #2
fbarchard1
Committed patchset #4 (id:60001) manually as 6732bcbde9c18d41080816343cc0c65bf265396b (presubmit successful).
4 years, 2 months ago (2016-09-27 21:18:36 UTC) #4
fbarchard1
4 years, 2 months ago (2016-09-27 22:14:19 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/2364293002/diff/60001/source/row_win.cc
File source/row_win.cc (right):

https://codereview.chromium.org/2364293002/diff/60001/source/row_win.cc#newco...
source/row_win.cc:6113: vpmovzxwd   ymm0, xmmword ptr [eax]  // 8 shorts -> 8
ints
note vpmovzxwd is avx2 but other instructions are avx/f16c.
consider replacing vpmovzxwd  with mov/unpack to work on ivybridge.

Powered by Google App Engine
This is Rietveld 408576698