Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2364233003: suppressions.xml suppressions needed for Android SDK roll. (Closed)

Created:
4 years, 3 months ago by ghost stip (do not use)
Modified:
4 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

suppressions.xml suppressions needed for Android SDK roll. This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier. BUG=623989 Committed: https://crrev.com/8d53345794d41eb28671c65157fa3c0df093ba99 Cr-Commit-Position: refs/heads/master@{#422649}

Patch Set 1 #

Patch Set 2 : Rebase onto latest master. #

Patch Set 3 : Address jbudorick's changes. #

Patch Set 4 : Add TODOs. #

Patch Set 5 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -170 lines) Patch
M build/android/lint/suppressions.xml View 1 2 3 4 1 chunk +256 lines, -170 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ghost stip (do not use)
ptal!
4 years, 2 months ago (2016-10-03 22:23:18 UTC) #3
jbudorick
lgtm
4 years, 2 months ago (2016-10-03 22:33:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364233003/60001
4 years, 2 months ago (2016-10-03 23:12:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/41666)
4 years, 2 months ago (2016-10-03 23:37:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364233003/80001
4 years, 2 months ago (2016-10-03 23:46:49 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-04 01:08:49 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:12:23 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8d53345794d41eb28671c65157fa3c0df093ba99
Cr-Commit-Position: refs/heads/master@{#422649}

Powered by Google App Engine
This is Rietveld 408576698