Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2364113003: Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 0f8372ca68ff94845b079a6856a6f912b533bcb8..126df71c74b3b788f1836af075d0ad7733688228 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -791,6 +791,32 @@
g_renderer_main_thread_factory = create;
}
+// static
+// TODO(alokp): Remove after collecting crash data.
+// Temporary checks to verify that all shared workers are terminated.
+// It is suspected that shared workers prevent render process hosts
+// from shutting down: crbug.com/608049
+void RenderProcessHostImpl::CheckAllWorkersTerminated() {
+ iterator iter(AllHostsIterator());
+ while (!iter.IsAtEnd()) {
+ RenderProcessHostImpl* host =
+ static_cast<RenderProcessHostImpl*>(iter.GetCurrentValue());
+ if (host->worker_ref_count() != 0) {
+ std::string message = base::StringPrintf(
+ "%zu service workers, %zu shared workers",
+ host->service_worker_ref_count_, host->shared_worker_ref_count_);
+ // Use separate CHECKs for better crash report readability.
+ CHECK(host->service_worker_ref_count_ == 0 ||
+ host->shared_worker_ref_count_ == 0)
+ << message;
+ CHECK_EQ(0UL, host->service_worker_ref_count_) << message;
+ CHECK_EQ(0UL, host->shared_worker_ref_count_) << message;
+ }
+
+ iter.Advance();
+ }
+}
+
RenderProcessHostImpl::~RenderProcessHostImpl() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
#ifndef NDEBUG
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/browser/shared_worker/shared_worker_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698