Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2364113003: Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)

Created:
4 years, 2 months ago by falken
Modified:
4 years, 2 months ago
Reviewers:
jam, horo
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (patchset #1 id:1 of https://codereview.chromium.org/2338113002/ ) Reason for revert: Relanding after the attempted fix in https://crrev.com/04a6912a1a2b77faf61e4b2514b9ecff74ee1f21 Original issue's description: > Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://codereview.chromium.org/2254963002/ )" > > This reverts commit d1109b15f8669b2c342d87e9ae6e5d8ebd669ada. > > The crash rate is too high and polluting crash report data. > I'll reland it when the fix lands. > > BUG=636377 > TBR=jam > > Committed: https://crrev.com/2639679013cd3c2bbf7603cd805a0ba3641f7055 > Cr-Commit-Position: refs/heads/master@{#418462} TBR=horo@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636377 Committed: https://crrev.com/7142fe697d2cdc121b2e3a4e0af9d9fe7f6c153f Cr-Commit-Position: refs/heads/master@{#420848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
falken
Created Revert of Revert "Reland of Check that all shared workers are terminated. (patchset #2 ...
4 years, 2 months ago (2016-09-24 15:30:08 UTC) #1
falken
4 years, 2 months ago (2016-09-24 15:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364113003/1
4 years, 2 months ago (2016-09-24 15:34:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-24 17:03:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7142fe697d2cdc121b2e3a4e0af9d9fe7f6c153f Cr-Commit-Position: refs/heads/master@{#420848}
4 years, 2 months ago (2016-09-24 17:06:22 UTC) #9
horo
lgtm
4 years, 2 months ago (2016-09-26 00:59:12 UTC) #10
falken
4 years, 2 months ago (2016-10-03 01:00:24 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2385053002/ by falken@chromium.org.

The reason for reverting is: These temporary CHECKs can be removed because they
are passing on Canary..

Powered by Google App Engine
This is Rietveld 408576698