src/incremental-marking.cc - Issue 23641009: Refactor and cleanup VirtualMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/incremental-marking.cc

Issue 23641009: Refactor and cleanup VirtualMemory. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed nits. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/incremental-marking.cc

diff --git a/src/incremental-marking.cc b/src/incremental-marking.cc

index df0f14a74cef8363e51c98bd3bdc8d2e60b44309..4d46b66fa4e853feb707d566ae51ca45c4a4df23 100644

--- a/src/incremental-marking.cc

+++ b/src/incremental-marking.cc

@@ -558,7 +558,7 @@ void IncrementalMarking::EnsureMarkingDequeIsCommitted() {

bool success = marking_deque_memory_->Commit(

reinterpret_cast<Address>(marking_deque_memory_->address()),

marking_deque_memory_->size(),

- false); // Not executable.

+ VirtualMemory::NOT_EXECUTABLE);

CHECK(success);

marking_deque_memory_committed_ = true;

}

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »