Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: test/cctest/test-code-stubs-ia32.cc

Issue 23641009: Refactor and cleanup VirtualMemory. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nits. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-code-stubs-arm.cc ('k') | test/cctest/test-code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 29 matching lines...) Expand all
40 40
41 using namespace v8::internal; 41 using namespace v8::internal;
42 42
43 #define __ assm. 43 #define __ assm.
44 44
45 ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate, 45 ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,
46 Register source_reg, 46 Register source_reg,
47 Register destination_reg) { 47 Register destination_reg) {
48 // Allocate an executable page of memory. 48 // Allocate an executable page of memory.
49 size_t actual_size; 49 size_t actual_size;
50 byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize, 50 byte* buffer = static_cast<byte*>(VirtualMemory::AllocateRegion(
51 &actual_size, 51 Assembler::kMinimalBufferSize,
52 true)); 52 &actual_size,
53 VirtualMemory::EXECUTABLE));
53 CHECK(buffer); 54 CHECK(buffer);
54 HandleScope handles(isolate); 55 HandleScope handles(isolate);
55 MacroAssembler assm(isolate, buffer, static_cast<int>(actual_size)); 56 MacroAssembler assm(isolate, buffer, static_cast<int>(actual_size));
56 assm.set_allow_stub_calls(false); 57 assm.set_allow_stub_calls(false);
57 int offset = 58 int offset =
58 source_reg.is(esp) ? 0 : (HeapNumber::kValueOffset - kSmiTagSize); 59 source_reg.is(esp) ? 0 : (HeapNumber::kValueOffset - kSmiTagSize);
59 DoubleToIStub stub(source_reg, destination_reg, offset, true); 60 DoubleToIStub stub(source_reg, destination_reg, offset, true);
60 byte* start = stub.GetCode(isolate)->instruction_start(); 61 byte* start = stub.GetCode(isolate)->instruction_start();
61 62
62 __ push(ebx); 63 __ push(ebx);
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 142
142 for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) { 143 for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) {
143 for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) { 144 for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
144 RunAllTruncationTests( 145 RunAllTruncationTests(
145 MakeConvertDToIFuncTrampoline(isolate, 146 MakeConvertDToIFuncTrampoline(isolate,
146 source_registers[s], 147 source_registers[s],
147 dest_registers[d])); 148 dest_registers[d]));
148 } 149 }
149 } 150 }
150 } 151 }
OLDNEW
« no previous file with comments | « test/cctest/test-code-stubs-arm.cc ('k') | test/cctest/test-code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698