Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(5)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable.html
Issue
23641004
:
Ignore should-scroll-on-main-thread if main frame is not scrollable (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: .
Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable.css
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable.html
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable-expected.txt
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt
Source/core/page/FrameView.cpp
Source/core/page/scrolling/ScrollingCoordinator.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable.css
('k') |
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable-expected.txt »
('j') |
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable-expected.txt »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<html>
3
<head>
4
<link rel="stylesheet" type="text/css" href="do-not-crash-when-checking-frame- view-is-scrollable.css">
5
<script src="../../fast/js/resources/js-test-pre.js"></script>
6
<script>
7
document.createElement("div").offsetParent;
8
9
if (window.internals) {
10
testPassed("Did not crash");
11
} else {
12
description("This test ensures that we do not crash when the document bo dy has no style when" +
13
" we check if the main frame is scrollable (which it is in t his case).");
14
}
15
</script>
16
<script src="../../fast/js/resources/js-test-post.js"></script>
17
</head>
18
<body>
19
</body>
20
</html>
21
OLD
NEW
« no previous file with comments
|
« LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable.css
('k') |
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable-expected.txt »
('j') |
LayoutTests/compositing/overflow/do-not-crash-when-checking-frame-view-is-scrollable-expected.txt »
('J')
Issue 23641004: Ignore should-scroll-on-main-thread if main frame is not scrollable (Closed)
Created 7 years, 3 months ago by Ian Vollick
Modified 7 years, 3 months ago
Reviewers: jamesr
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 2
This is Rietveld
408576698