Fix status bar color not updating when applying a theme on Linux.

Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
Committed: https://crrev.com/cbf5bacde72383a2b88fd476bfd1bc5460a20ae7
Cr-Commit-Position: refs/heads/master@{#420851}

[Bret, 2016-09-23 23:57:35]

Description was changed from

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
==========

to

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
==========

[Bret, 2016-09-23 23:57:35]

bsep@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-09-24 06:07:40]

LGTM

https://codereview.chromium.org/2364063003/diff/1/chrome/browser/ui/views/sta...
File chrome/browser/ui/views/status_bubble_views.cc (right):

https://codereview.chromium.org/2364063003/diff/1/chrome/browser/ui/views/sta...
chrome/browser/ui/views/status_bubble_views.cc:214: const ui::ThemeProvider*
theme_provider,
So I know we're on the same page, the other solutions would be:

* Recreate the status bubble on theme change
* Have the status bubble listen for theme changes and update its colors
* Have something else listen for theme changes and tell the status bubble to
update its colors

Probably the second of these is the best of the three, since it seems simpler
than the third, and the first is about the same amount of effort as the third. 
But we'd only really do the second over this solution if getting the colors were
expensive, and it's not.  So this solution seems good.

It sounds like some platforms _do_ recreate the status bubble on theme changes? 
Do they really need to?  Maybe we can nuke that?

[Bret, 2016-09-24 19:28:36]

https://codereview.chromium.org/2364063003/diff/1/chrome/browser/ui/views/sta...
File chrome/browser/ui/views/status_bubble_views.cc (right):

https://codereview.chromium.org/2364063003/diff/1/chrome/browser/ui/views/sta...
chrome/browser/ui/views/status_bubble_views.cc:214: const ui::ThemeProvider*
theme_provider,
On 2016/09/24 06:07:40, Peter Kasting wrote:
> So I know we're on the same page, the other solutions would be:
> 
> * Recreate the status bubble on theme change
> * Have the status bubble listen for theme changes and update its colors
> * Have something else listen for theme changes and tell the status bubble to
> update its colors
> 
> Probably the second of these is the best of the three, since it seems simpler
> than the third, and the first is about the same amount of effort as the third.

> But we'd only really do the second over this solution if getting the colors
were
> expensive, and it's not.  So this solution seems good.
> 
> It sounds like some platforms _do_ recreate the status bubble on theme
changes? 
> Do they really need to?  Maybe we can nuke that?

Windows does nuke the class when the theme changes (even if it was already using
opaque frame) which is why I didn't catch it before. It doesn't seem like it
needs to, but it might be unavoidable for some reason. I haven't investigated
it.

No idea for other platforms. Since the bug I got was only for Linux I assume
that's the odd one out.

[Bret, 2016-09-24 19:28:41]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-09-24 19:28:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 20:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 20:29:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2016-09-24 20:42:33]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-09-24 20:42:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 21:28:52]

Description was changed from

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
==========

to

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
==========

[commit-bot: I haz the power, 2016-09-24 21:28:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-24 21:30:33]

Description was changed from

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601
==========

to

==========
Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG=649601

Committed: https://crrev.com/cbf5bacde72383a2b88fd476bfd1bc5460a20ae7
Cr-Commit-Position: refs/heads/master@{#420851}
==========

[commit-bot: I haz the power, 2016-09-24 21:30:34]

Patchset 1 (id:??) landed as
https://crrev.com/cbf5bacde72383a2b88fd476bfd1bc5460a20ae7
Cr-Commit-Position: refs/heads/master@{#420851}