Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2364063002: generate_gradle.py: Make --all restrict to apk targets (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

generate_gradle.py: Make --all restrict to apk targets This cuts down the sub-project count from 390->280. But Android Studio still runs out of memory (at least with default max heap settings). BUG=620034 Committed: https://crrev.com/6a823415411eacefa5b91ad24fc8bf24bd28c9cc Cr-Commit-Position: refs/heads/master@{#420681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/android/gradle/generate_gradle.py View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/09/23 15:26:49, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 2 months ago (2016-09-23 15:26:54 UTC) #3
jbudorick
lgtm
4 years, 2 months ago (2016-09-23 15:29:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364063002/1
4 years, 2 months ago (2016-09-23 17:42:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 18:51:18 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 18:55:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a823415411eacefa5b91ad24fc8bf24bd28c9cc
Cr-Commit-Position: refs/heads/master@{#420681}

Powered by Google App Engine
This is Rietveld 408576698