Issue 236403002: Remove Mac char code from PlatformKeyboardEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236403002: Remove Mac char code from PlatformKeyboardEvent. (Closed)

Created:
6 years, 8 months ago by jbroman

Modified:
6 years, 8 months ago

Reviewers:
eseidel, eae, abarth-chromium

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove Mac char code from PlatformKeyboardEvent. This field is never read. BUG=362927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171407

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	Source/core/inspector/InspectorInputAgent.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/platform/PlatformKeyboardEvent.h	View		3 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jbroman

There is a mechanism for supplying this field via the inspector (seen in InspectorInputAgent, devtools/Inspector-1.1.json, ...

6 years, 8 months ago (2014-04-13 00:41:30 UTC) #1

abarth-chromium

LGTM Maybe ask caseq or pfeldman what needs to be done on the inspector side?

6 years, 8 months ago (2014-04-13 06:52:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/236403002/1

6 years, 8 months ago (2014-04-13 13:22:28 UTC) #4

Message was sent while issue was closed.

Change committed as 171407

Expand Messages | Collapse Messages