Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2364003002: Fix test-parsing/InnerAssignment. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test-parsing/InnerAssignment. It looks like it tried to trigger lazy inner function parsing by inserting a comment into an inner function. 1) We don't have lazy inner functions yet. 2) Even if we had, there's no way this heuristic could trigger laziness: we need to do the laziness decision upfront, without looking at the contents / size of the function. 3) Some of the combinations were weird: lazy_outer but non-lazy inner? In the current heuristics, only the total script size affects laziness; in particular, it doesn't matter where the long comment is. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/83207f4853b8c833717e2c340bfebc070de4915d Cr-Commit-Position: refs/heads/master@{#39673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M test/cctest/test-parsing.cc View 2 chunks +37 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Starzinger
LGTM.
4 years, 3 months ago (2016-09-23 12:34:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364003002/1
4 years, 3 months ago (2016-09-23 12:35:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 14:30:21 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 14:30:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83207f4853b8c833717e2c340bfebc070de4915d
Cr-Commit-Position: refs/heads/master@{#39673}

Powered by Google App Engine
This is Rietveld 408576698