Ensure the sanitizer runtime library is copied to app bundle if enabled.

build/config/ios/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/clang/clang.gni")
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/base_rules.gni")
 import("//build/config/mac/symbols.gni")
+import("//build/config/sanitizers/sanitizers.gni")
 
 # Invokes lipo on multiple arch-specific binaries to create a fat binary.
 #
 # Arguments
 #
 #   arch_binary_target
 #     name of the target generating the arch-specific binaries, they must
 #     be named $target_out_dir/$toolchain_cpu/$arch_binary_output.
 #
 #   arch_binary_output
@@ skipping 120 matching lines @@
 #   bundle_binary_target
 #       string, label of the target generating the bundle main binary.
 #
 #   bundle_binary_output
 #       (optional) string, base name of the binary generated by the
 #       bundle_binary_target target, defaults to the target name.
 #
 #   extra_system_frameworks
 #       (optional) list of system framework to copy to the bundle.
 #
+#   extra_system_libraries
+#       (optional) list of system libraries to copy to the bundle.
+#
 #   enable_code_signing
 #       (optional) boolean, control whether code signing is enabled or not,
 #       default to ios_enable_code_signing if not defined.
 #
 template("create_signed_bundle") {
   assert(defined(invoker.product_type),
          "product_type must be defined for $target_name")
   assert(defined(invoker.bundle_extension),
          "bundle_extension must be defined for $target_name")
   assert(defined(invoker.bundle_binary_target),
@@ skipping 69 matching lines @@
       code_signing_outputs += [ "$_bundle_root_dir/embedded.mobileprovision" ]
     }
 
     if (defined(invoker.extra_system_frameworks)) {
       foreach(_framework, invoker.extra_system_frameworks) {
         code_signing_outputs += [ "$bundle_root_dir/Frameworks/" +
                                   get_path_info(_framework, "file") ]
       }
     }
 
+    if (defined(invoker.extra_system_libraries)) {
+      foreach(_library, invoker.extra_system_libraries) {
+        code_signing_outputs +=
+            [ "$bundle_root_dir/" + get_path_info(_library, "file") ]
+      }
+    }
+
     code_signing_args = [
       "code-sign-bundle",
       "-t=" + ios_sdk_name,
       "-i=" + ios_code_signing_identity,
       "-e=" + rebase_path(_entitlements_path, root_build_dir),
       "-b=" + rebase_path("$target_out_dir/$_output_name", root_build_dir),
       rebase_path(bundle_root_dir, root_build_dir),
     ]
     if (!_enable_code_signing) {
       code_signing_args += [ "--disable-code-signature" ]
     }
     if (defined(invoker.extra_system_frameworks)) {
       # All framework in extra_system_frameworks are expected to be
       # system framework and the path to be already system absolute
       # so do not use rebase_path here.
       foreach(_framework, invoker.extra_system_frameworks) {
         code_signing_args += [ "-F=" + _framework ]
       }
     }
+    if (defined(invoker.extra_system_libraries)) {
+      # All libraries in extra_system_libraries are expected to be
+      # system libraries and the path to be already system absolute
+      # so do not use rebase_path here.
+      foreach(_library, invoker.extra_system_libraries) {
+        code_signing_args += [ "-L=" + _library ]
+      }
+    }
   }
 }
 
 # Generates Info.plist files for Mac apps and frameworks.
 #
 # Arguments
 #
 #     info_plist:
 #         (optional) string, path to the Info.plist file that will be used for
 #         the bundle.
@@ skipping 332 matching lines @@
         data_deps += [ "//testing/iossim" ]
       }
 
       if (!defined(product_type)) {
         product_type = "com.apple.product-type.application"
       }
 
       if (!defined(bundle_extension)) {
         bundle_extension = ".app"
       }
+
+      if (using_sanitizer) {
+        if (!defined(extra_system_libraries)) {
+          extra_system_libraries = []
+        }
+        extra_system_libraries +=
+            [ rebase_path("$clang_base_path/lib/clang/$clang_version/lib/" +
+                              "darwin/libclang_rt.asan_iossim_dynamic.dylib",

[justincohen, 2016/09/26 15:14:02]

does this change if we are building with Xcode clang?

[sdefresne, 2016/09/26 15:20:43]

Yes, it will probably change, though we currently have no configuration
supporting ASAN and Xcode clang (I'm pretty sure that even without my patch
compilation will fail if you enable both). Do we want to support this
configuration?

[justincohen, 2016/09/26 16:09:00]

I think at least a comment explaining this won't work with Xcode's clang is good
enough.

+                          root_build_dir) ]
+      }
     }
   }
 }
 
 set_defaults("ios_app_bundle") {
   configs = default_executable_configs
 }
 
 # Template to build an application extension bundle for iOS.
 #
@@ skipping 27 matching lines @@
   ios_app_bundle(target_name) {
     forward_variables_from(invoker,
                            "*",
                            [
                              "bundle_extension",
                              "product_type",
                            ])
     bundle_extension = ".appex"
     product_type = "com.apple.product-type.app-extension"
 
+    # The application extensions use the same runtime library as their main
+    # application, so filter the bundle deps from the application extension
+    # bundle.
+    if (using_sanitizer) {
+      if (!defined(bundle_deps_filter)) {
+        bundle_deps_filter = []
+      }
+      bundle_deps_filter +=
+          [ "//build/config/sanitizers:asan_runtime_bundle_data" ]
+    }
+
     # Add linker flags required for an application extension (determined by
     # inspecting the link command-line when using Xcode 9.0+).
     if (!defined(ldflags)) {
       ldflags = []
     }
     ldflags += [
       "-e",
       "_NSExtensionMain",
       "-fapplication-extension",
     ]
@@ skipping 676 matching lines @@
       "-rpath",
       "-Xlinker",
       "@loader_path/Frameworks",
     ]
   }
 }
 
 set_defaults("ios_xctest_test") {
   configs = default_executable_configs
 }