Ensure the sanitizer runtime library is copied to app bundle if enabled.

build/config/ios/codesign.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import fnmatch
 import glob
 import os
 import plistlib
 import shutil
@@ skipping 179 matching lines @@
     sys.exit(process.returncode)
   for line in stderr.splitlines():
     if line.endswith(': replacing existing signature'):
       # Ignore warning about replacing existing signature as this should only
       # happen when re-signing system frameworks (and then it is expected).
       continue
     sys.stderr.write(line)
     sys.stderr.write('\n')
 
 
+def InstallSystemFrameworkOrLibrary(src_path, dst_path, args):
+  """Install framework or library from |src_path| to |dst_path| and
+  code-re-sign it."""
+  if os.path.isdir(dst_path):
+    shutil.rmtree(dst_path)

[justincohen, 2016/09/26 15:14:02]

Is this the same thing Xcode does with it's build in asan?

[sdefresne, 2016/09/26 15:20:43]

No, it put he asan library into ${app}.app/Frameworks but the asan library built
with Chromium has an install_name of
@executable_path/libclang_rt.asan_iossim_dynamic.dylib while the one from Xcode
has an install_name of
@executable_path/Frameworks/libclang_rt.asan_iossim_dynamic.dylib.

It needs to be code signed though (and Xcode do code sign the runtime library it
copies).

[justincohen, 2016/09/26 16:09:00]

Acknowledged.

+  elif os.path.isfile(dst_path):
+    os.unlink(dst_path)
+
+  if os.path.isdir(src_path):
+    shutil.copytree(src_path, dst_path)
+  else:
+    shutil.copy(src_path, dst_path)
+
+  CodeSignBundle(dst_path, args.identity,
+      ['--deep', '--preserve-metadata=identifier,entitlements'])
+
+
 def InstallSystemFramework(framework_path, bundle_path, args):
   """Install framework from |framework_path| to |bundle| and code-re-sign it."""
   installed_framework_path = os.path.join(
       bundle_path, 'Frameworks', os.path.basename(framework_path))
+  InstallSystemFrameworkOrLibrary(
+      framework_path, installed_framework_path, args)
 
-  if os.path.exists(installed_framework_path):
-    shutil.rmtree(installed_framework_path)
 
-  shutil.copytree(framework_path, installed_framework_path)
-  CodeSignBundle(installed_framework_path, args.identity,
-      ['--deep', '--preserve-metadata=identifier,entitlements'])
+def InstallSystemLibrary(library_path, bundle_path, args):
+  """Install library from |library_path| to |bundle| and code-re-sign it."""
+  installed_library_path = os.path.join(
+      bundle_path, os.path.basename(library_path))
+  InstallSystemFrameworkOrLibrary(
+      library_path, installed_library_path, args)
 
 
 def GenerateEntitlements(path, provisioning_profile, bundle_identifier):
   """Generates an entitlements file.
 
   Args:
     path: path to the entitlements template file
     provisioning_profile: ProvisioningProfile object to use, may be None
     bundle_identifier: identifier of the bundle to sign.
   """
@@ skipping 36 matching lines @@
     parser.add_argument(
         'path', help='path to the iOS bundle to codesign')
     parser.add_argument(
         '--identity', '-i', required=True,
         help='identity to use to codesign')
     parser.add_argument(
         '--binary', '-b', required=True,
         help='path to the iOS bundle binary')
     parser.add_argument(
         '--framework', '-F', action='append', default=[], dest='frameworks',
-        help='install and resign system framework')
+        help='install and re-sign system framework')
+    parser.add_argument(
+        '--library', '-L', action='append', default=[], dest='libraries',
+        help='install and re-sign system libraries')
     parser.add_argument(
         '--disable-code-signature', action='store_false', dest='sign',
         help='disable code signature')
     parser.add_argument(
         '--platform', '-t', required=True,
         help='platform the signed bundle is targetting')
     parser.set_defaults(sign=True)
 
   @staticmethod
   def _Execute(args):
@@ skipping 13 matching lines @@
 
     # Delete existing code signature.
     signature_file = os.path.join(args.path, '_CodeSignature', 'CodeResources')
     if os.path.isfile(signature_file):
       os.unlink(signature_file)
 
     # Install system frameworks if requested.
     for framework_path in args.frameworks:
       InstallSystemFramework(framework_path, args.path, args)
 
+    # Install system libraries if requested.
+    for library_path in args.libraries:
+      InstallSystemLibrary(library_path, args.path, args)
+
     # Copy main binary into bundle.
     if os.path.isfile(bundle.binary_path):
       os.unlink(bundle.binary_path)
     shutil.copy(args.binary, bundle.binary_path)
 
     if not args.sign:
       return
 
     # Embeds entitlements into the code signature (if code signing identify has
     # been provided).
@@ skipping 44 matching lines @@
 
   for action in [ CodeSignBundleAction, GenerateEntitlementsAction ]:
     action.Register(subparsers)
 
   args = parser.parse_args()
   args.func(args)
 
 
 if __name__ == '__main__':
   sys.exit(Main())